Close restore and attach form right after receiving the job id#6603
Merged
yadvr merged 1 commit intoapache:mainfrom Aug 3, 2022
Merged
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
approved these changes
Aug 3, 2022
yadvr
approved these changes
Aug 3, 2022
neogismm
pushed a commit
to neogismm/cloudstack
that referenced
this pull request
Aug 6, 2022
When restoring and attaching a backup volume, the UI waits for the successfful response of the API to close the formulary. However, letting the form open after sending the command can confuse users, that might try to send the command again. Note: other formularies (like volume or snapshot creation) always are closed after sending the command to the backend. With this PR, we intend to close the formulary right after sending the command, as done with others. Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When restoring and attaching a backup volume, the UI waits for the successfful response of the API to close the formulary. However, letting the form open after sending the command can confuse users, that might try to send the command again.
Note: other formularies (like volume or snapshot creation) always are closed after sending the command to the backend.
With this PR, we intend to close the formulary right after sending the command, as done with others.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It was tested in a local lab.
Before the changes, I tried to restore and attach a backup volume. After clicking the button
Ok, the command was sent, but the formulary was kept open. After the changes, when clicking the buttonOk, the command is sent and the formulary is closed.