Skip to content

Refactor TestHttp.testHttpclient to avoid the Exception Suppression #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Oct 9, 2022
Merged

Refactor TestHttp.testHttpclient to avoid the Exception Suppression #6733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3025e06
Refactor TestHttp.testHttpclient to avoid the Exception Suppression
Codegass Sep 12, 2022
f1aff02
Remove the unnecessary import
Codegass Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions ...e/storage/integration-test/src/test/java/org/apache/cloudstack/storage/test/TestHttp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

import org.apache.http.HttpEntity;
import org.apache.http.HttpResponse;
import org.apache.http.client.ClientProtocolException;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.client.methods.HttpHead;
import org.apache.http.impl.client.DefaultHttpClient;
Expand All @@ -41,7 +40,7 @@
public class TestHttp extends AbstractTestNGSpringContextTests {
@Test
@Parameters("template-url")
public void testHttpclient(String templateUrl) {
public void testHttpclient(String templateUrl) throws IOException {
final HttpHead method = new HttpHead(templateUrl);
final DefaultHttpClient client = new DefaultHttpClient();

Expand All @@ -62,20 +61,9 @@ public void testHttpclient(String templateUrl) {

output = new BufferedOutputStream(new FileOutputStream(localFile));
entity.writeTo(output);
} catch (final ClientProtocolException e) {
// TODO Auto-generated catch block
e.printStackTrace();
} catch (final IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
} finally {
try {
if (output != null) {
output.close();
}
} catch (final IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
if (output != null) {
output.close();
}
}

Expand Down