fix usage charging for deleted/resized volumes

[DaanHoogland]

Description

This PR Fixes #6717

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6737 (SL-JID-2354)

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4187

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[codecov]

Codecov Report

Merging #6737 (90b5841) into main (c3d6f42) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6737      +/-   ##
============================================
+ Coverage     10.34%   10.41%   +0.07%     
- Complexity     6611     6694      +83     
============================================
  Files          2451     2455       +4     
  Lines        242338   243141     +803     
  Branches      37923    38062     +139     
============================================
+ Hits          25064    25335     +271     
- Misses       214187   214637     +450     
- Partials       3087     3169      +82     

Impacted Files	Coverage Δ
.../cloudstack/api/response/ApiDiscoveryResponse.java	0.00% <0.00%> (-100.00%)	⬇️
.../cloudstack/api/response/ApiParameterResponse.java	0.00% <0.00%> (-100.00%)	⬇️
...e/cloudstack/api/response/ApiResponseResponse.java	0.00% <0.00%> (-80.00%)	⬇️
.../cloudstack/discovery/ApiDiscoveryServiceImpl.java	13.93% <0.00%> (-55.25%)	⬇️
...rc/main/java/com/cloud/storage/StorageManager.java	76.92% <0.00%> (-23.08%)	⬇️
.../cloudstack/ratelimit/ApiRateLimitServiceImpl.java	68.88% <0.00%> (-4.45%)	⬇️
.../main/java/com/cloud/hypervisor/XenServerGuru.java	46.39% <0.00%> (-2.03%)	⬇️
...rc/main/java/org/apache/cloudstack/acl/RoleVO.java	53.57% <0.00%> (-1.99%)	⬇️
...ema/src/main/java/com/cloud/network/vpc/VpcVO.java	14.86% <0.00%> (-1.81%)	⬇️
...ain/java/com/cloud/network/dao/LoadBalancerVO.java	58.62% <0.00%> (-0.64%)	⬇️
... and 84 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Trillian test result (tid-4903)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6737-t4903-kvm-centos7.zip
Smoke tests completed. 102 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. LL-JID 185

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-5037)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39944 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6737-t5037-kvm-centos7.zip
Smoke tests completed. 101 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	583.55	test_kubernetes_clusters.py

[DaanHoogland]

@shwstppr can you review this please?

[shwstppr]

LGTM