Skip to content

server: fix exception in DeploymentPlanningManagerImplTest#6799

Merged
yadvr merged 1 commit intoapache:mainfrom
weizhouapache:4.18-fix-NPE-DeploymentPlanningManagerImplTest
Oct 4, 2022
Merged

server: fix exception in DeploymentPlanningManagerImplTest#6799
yadvr merged 1 commit intoapache:mainfrom
weizhouapache:4.18-fix-NPE-DeploymentPlanningManagerImplTest

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

previously

[INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest

java.lang.NullPointerException
	at com.cloud.deploy.DeploymentPlanningManagerImpl.planDeployment(DeploymentPlanningManagerImpl.java:403)
	at com.cloud.deploy.DeploymentPlanningManagerImplTest.failEncRootLastHostNotSupportingEncryptionTest(DeploymentPlanningManagerImplTest.java:644)

...
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.407 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest

with this PR

[INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest

[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.481 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • [] Minor
  • [x ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

previously
```
[INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest

java.lang.NullPointerException
	at com.cloud.deploy.DeploymentPlanningManagerImpl.planDeployment(DeploymentPlanningManagerImpl.java:403)
	at com.cloud.deploy.DeploymentPlanningManagerImplTest.failEncRootLastHostNotSupportingEncryptionTest(DeploymentPlanningManagerImplTest.java:644)

...
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.407 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest

```

with this PR

```
[INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest

[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.481 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
```
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4344

@yadvr yadvr added this to the 4.18.0.0 milestone Oct 4, 2022
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Oct 4, 2022

I dont' see any unit test failures.

@yadvr yadvr merged commit c83dee5 into apache:main Oct 4, 2022
@weizhouapache weizhouapache deleted the 4.18-fix-NPE-DeploymentPlanningManagerImplTest branch December 9, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants