Skip to content

Improves email configurations descriptions#6806

Merged
yadvr merged 4 commits intoapache:mainfrom
scclouds:fix-email-configs-description
Oct 8, 2022
Merged

Improves email configurations descriptions#6806
yadvr merged 4 commits intoapache:mainfrom
scclouds:fix-email-configs-description

Conversation

@stephankruggg
Copy link
Copy Markdown
Contributor

@stephankruggg stephankruggg commented Oct 4, 2022

Description

The alert.email.addresses description is ambiguous and can cause doubts to operators. This description has been altered to avoid confusion. In addition, typos in alert.smtp.useStartTLS and project.smtp.useStartTLS have been fixed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

In a local lab I applied this patch and the descriptions were successfully updated.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Oct 4, 2022

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2022

Codecov Report

Merging #6806 (55d7fb8) into main (713a236) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 55d7fb8 differs from pull request most recent head b6e449b. Consider uploading reports for the commit b6e449b to get more accurate results

@@             Coverage Diff              @@
##               main    #6806      +/-   ##
============================================
- Coverage     10.60%   10.54%   -0.07%     
+ Complexity     6849     6788      -61     
============================================
  Files          2466     2464       -2     
  Lines        244549   244168     -381     
  Branches      38262    38205      -57     
============================================
- Hits          25936    25741     -195     
+ Misses       215331   215178     -153     
+ Partials       3282     3249      -33     
Impacted Files Coverage Δ
...pi/src/main/java/com/cloud/alert/AlertManager.java 100.00% <ø> (ø)
.../src/main/java/com/cloud/configuration/Config.java 89.23% <ø> (ø)
...c/main/java/com/cloud/projects/ProjectManager.java 0.00% <ø> (ø)
...ne/schema/src/main/java/com/cloud/vm/UserVmVO.java 28.57% <0.00%> (-19.16%) ⬇️
...dstack/network/contrail/model/ModelObjectBase.java 21.15% <0.00%> (-7.70%) ⬇️
...in/java/com/cloud/server/ManagementServerImpl.java 2.47% <0.00%> (-2.73%) ⬇️
...n/java/com/cloud/template/TemplateManagerImpl.java 10.97% <0.00%> (-1.41%) ⬇️
...chema/src/main/java/com/cloud/vm/VMInstanceVO.java 34.52% <0.00%> (-1.20%) ⬇️
...a/com/cloud/network/router/CommandSetupHelper.java 0.12% <0.00%> (-1.14%) ⬇️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 5.60% <0.00%> (-1.01%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoaoJandre
Copy link
Copy Markdown
Contributor

@stephankruggg we could use some revision in QuotaConfig.java as well.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 5, 2022

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.18.0.0 milestone Oct 8, 2022
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Oct 8, 2022

Given the changes are in doc strings of Config/ConfigKey and Travis has passed, merging based on that.

@yadvr yadvr merged commit b8d834e into apache:main Oct 8, 2022
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Oct 8, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants