Skip to content

[UI] CreateNetwork isolated/L2 form, added accounts list under selected domain#7393

Merged
yadvr merged 3 commits intoapache:4.18from
shapeblue:UIAccountsListInCreateNetworkForm
Apr 11, 2023
Merged

[UI] CreateNetwork isolated/L2 form, added accounts list under selected domain#7393
yadvr merged 3 commits intoapache:4.18from
shapeblue:UIAccountsListInCreateNetworkForm

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Apr 3, 2023

Description

Currently create network form takes account name (manual entry) as one of the parameters. During network creation we check if the given account name is under selected domain.

Here with this PR we are listing accounts under the selected domain.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@harikrishna-patnala harikrishna-patnala force-pushed the UIAccountsListInCreateNetworkForm branch from 0d6dba4 to a573fcd Compare April 3, 2023 09:19
@harikrishna-patnala harikrishna-patnala changed the title CreateNetwork isolated/L2 form, added accounts list under selected domain [UI] CreateNetwork isolated/L2 form, added accounts list under selected domain Apr 3, 2023
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7393 (QA-JID-69)

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7393 (QA-JID-71)

@weizhouapache
Copy link
Copy Markdown
Member

@harikrishna-patnala
would be better to display Domain and Account together ?

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@weizhouapache here it is

image

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2023

Codecov Report

Merging #7393 (ba9c84e) into 4.18 (ce98157) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7393   +/-   ##
=========================================
  Coverage     12.69%   12.69%           
- Complexity     8660     8662    +2     
=========================================
  Files          2717     2717           
  Lines        256166   256168    +2     
  Branches      39928    39928           
=========================================
+ Hits          32518    32528   +10     
+ Misses       219514   219504   -10     
- Partials       4134     4136    +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland
Copy link
Copy Markdown
Contributor

@weizhouapache here it is

image

maybe pollish a bit @harikrishna-patnala ; convention seems to be first account and after that domain...?

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@weizhouapache here it is
image

maybe pollish a bit @harikrishna-patnala ; convention seems to be first account and after that domain...?

First Domain and then accounts in that selected Domain @DaanHoogland

@yadvr yadvr added this to the 4.18.1.0 milestone Apr 6, 2023
@DaanHoogland
Copy link
Copy Markdown
Contributor

First Domain and then accounts in that selected Domain @DaanHoogland

This is not the general practice over the whole system, but let's call that out of scope for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants