make NoopDbUpgrade do a systemvm template check

[DaanHoogland]

Description

This PR adds systemvm upgrade check to the noop upgrade
Fixes: #6980

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[codecov]

Codecov Report

Merging #7564 (eba3b1d) into 4.18 (f9b7bcf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7564      +/-   ##
============================================
- Coverage     13.02%   13.01%   -0.01%     
  Complexity     9029     9029              
============================================
  Files          2720     2720              
  Lines        256998   257007       +9     
  Branches      40081    40081              
============================================
  Hits          33462    33462              
- Misses       219336   219345       +9     
  Partials       4200     4200              

Files Changed	Coverage Δ
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	40.24% <0.00%> (-1.53%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6173

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6623)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7564-t6623-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[yadvr]

Needs another review and perhaps testing, LGTM

[DaanHoogland]

Needs another review and perhaps testing, LGTM

@vladimirpetrov promised some testing, let's see what he finds.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6569

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7182)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53725 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7564-t7182-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	79.78	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	58.54	test_vm_life_cycle.py

[DaanHoogland]

running an upgrade test from 4.14 to this...

[vladimirpetrov]

LGTM based on manual testing. I did various upgrades and found no issues.