Skip to content

make NoopDbUpgrade do a systemvm template check #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
Jul 31, 2023
Merged

make NoopDbUpgrade do a systemvm template check #7564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,11 @@ private void decryptInit(Connection conn) throws SQLException {
}

@VisibleForTesting
protected static final class NoopDbUpgrade implements DbUpgrade {
protected static final class NoopDbUpgrade implements DbUpgrade, DbUpgradeSystemVmTemplate {

private final String upgradedVersion;
private final String[] upgradeRange;
private SystemVmTemplateRegistration systemVmTemplateRegistration;

private NoopDbUpgrade(final CloudStackVersion fromVersion, final CloudStackVersion toVersion) {

Expand Down Expand Up @@ -488,5 +489,19 @@ public InputStream[] getCleanupScripts() {
return new InputStream[0];
}

private void initSystemVmTemplateRegistration() {
systemVmTemplateRegistration = new SystemVmTemplateRegistration("");
}

@Override
public void updateSystemVmTemplates(Connection conn) {
s_logger.debug("Updating System Vm template IDs");
initSystemVmTemplateRegistration();
try {
systemVmTemplateRegistration.updateSystemVmTemplates(conn);
} catch (Exception e) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
}
}