Skip to content

cloudutils: fix adding rocky9 host failure due to missing /etc/sysconfig/libvirtd#7779

Merged
weizhouapache merged 1 commit intoapache:4.18from
weizhouapache:4.18-fix-rocky9-host
Jul 28, 2023
Merged

cloudutils: fix adding rocky9 host failure due to missing /etc/sysconfig/libvirtd#7779
weizhouapache merged 1 commit intoapache:4.18from
weizhouapache:4.18-fix-rocky9-host

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jul 27, 2023

Description

This PR fixes the issue while adding rocky9 host failure due to missing /etc/sysconfig/libvirtd

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@boring-cyborg boring-cyborg Bot added the Python Warning... Python code Ahead! label Jul 27, 2023
@weizhouapache weizhouapache added this to the 4.18.1.0 milestone Jul 27, 2023
DaanHoogland
DaanHoogland reviewed Jul 27, 2023
View reviewed changes
Comment thread python/lib/cloudutils/configFileOps.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 27, 2023

Codecov Report

Merging #7779 (eb82446) into 4.18 (cdf0187) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7779   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
  Complexity     9029     9029           
=========================================
  Files          2720     2720           
  Lines        256998   256998           
  Branches      40081    40081           
=========================================
  Hits          33462    33462           
  Misses       219336   219336           
  Partials       4200     4200

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6582

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 27, 2023

@blueorangutan test rocky9 kvm-rocky9

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@DaanHoogland [SF] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 28, 2023

[SF] Trillian test result (tid-7184)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 44290 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7184-kvm-alma9.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 28, 2023

[SF] Trillian test result (tid-7190)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44737 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7190-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 28, 2023

[SF] Trillian test result (tid-7189)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 47144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7189-kvm-alma9.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

shwstppr
shwstppr approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Test results also show no errors on Alma9

@weizhouapache currently we don't have support for Rocky9 on Trillian. Last time it was failing for me with some ansible version, syntax issue.
Oracle Linux 9 should work though

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 28, 2023

Code LGTM. Test results also show no errors on Alma9

@weizhouapache currently we don't have support for Rocky9 on Trillian. Last time it was failing for me with some ansible version, syntax issue. Oracle Linux 9 should work though

@shwstppr yeah, there could be some other issues while setting up a rocky9 environment.
Rohit has shared the steps in his testing: https://gist.github.com/rohityadavcloud/fc401a0fe8e8ea16b4b3a4e3d149ce0c
let's test it later

@weizhouapache weizhouapache merged commit d89d405 into apache:4.18 Jul 28, 2023
@DaanHoogland DaanHoogland deleted the 4.18-fix-rocky9-host branch July 28, 2023 09:04
DaanHoogland added a commit that referenced this pull request Jul 31, 2023
@DaanHoogland
Merge release branch 4.18 to main
d51d8a4 
* 4.18:
  UI: Filter templates by zone and hypervisor type when reinstall a VM (#7739)
  KVM: fix SSVM starting when overprovisioning memory (#7663)
  pom.xml: add property project.systemvm.template.location (#7706)
  cloudutils: fix adding rocky9 host failure due to missing /etc/sysconfig/libvirtd (#7779)
  server: get id from persisted object ReservationVO (#7785)
  search in (too) large result sets (#7766)
  ui: fix 404 error when list volumes of system vms (#7772)
  packaging: install tzdata-java on centos7/centos8 (#7768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @DaanHoogland @shwstppr