server: get id from persisted object ReservationVO

[DaanHoogland]

Description

This PR fixes a bug that broke a test in CheckedReservationTest. Not sure why it didn't show before (on merge and healthcheck).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

unit test passes:

[INFO] Running com.cloud.resourcelimit.CheckedReservationTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.055 s - in com.cloud.resourcelimit.CheckedReservationTest

[shwstppr]

Code LGTM

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #7785 (9b41e7d) into 4.18 (cdf0187) will not change coverage.
Report is 1 commits behind head on 4.18.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               4.18    #7785   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
  Complexity     9029     9029           
=========================================
  Files          2720     2720           
  Lines        256998   256998           
  Branches      40081    40081           
=========================================
  Hits          33462    33462           
  Misses       219336   219336           
  Partials       4200     4200           

Files Changed	Coverage Δ
...va/com/cloud/resourcelimit/CheckedReservation.java	48.83% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6589

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

@DaanHoogland
test looks good on my laptop, without any change.
where did you see the error ?

[DaanHoogland]

@DaanHoogland test looks good on my laptop, without any change. where did you see the error ?

locally, both on a dev branch and on 4.18 sec. I didn't see it on the health check for 4.18 either, but the change is a good improvement so I want it anyway.

[weizhouapache]

@DaanHoogland test looks good on my laptop, without any change. where did you see the error ?

locally, both on a dev branch and on 4.18 sec. I didn't see it on the health check for 4.18 either, but the change is a good improvement so I want it anyway.

Ok, lgtm

[blueorangutan]

[SF] Trillian test result (tid-7192)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7785-t7192-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	81.73	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	52.33	test_vm_life_cycle.py