Skip to content

Fix role escalation prevention #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Aug 18, 2023
Merged

Fix role escalation prevention #7853

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d395b0
fix role escalation prevention
Jul 25, 2023
a4d0f20
change isEnabled return
Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...c-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ public boolean checkAccess(User user, String commandName) throws PermissionDenie

@Override
public boolean checkAccess(Account account, String commandName) {
if (isEnabled()) {
return true;
}
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this prevents the escalation talked about fine, but it seems illogical to return true to prevent access. would return false not make more sense?

Copy link
Copy Markdown
Member Author

@hsato03 hsato03 Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland I don't think so. Actually this isEnabled method checks if DynamicRoleBasedAPIAccessChecker is enabled. Returning true here is just passing the check responsibility to another class.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @hsato03 I think you are right. I consider it a bug that the StaticRoleBasedAPIAccessChecker.isEnabled() would return true if it is disabled (but the dynamic one is enabled). Maybe this is a discussion out of scope for your change. As said, "if this prevents the escalation talked about (it is) fine"

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it looks like a bug @DaanHoogland
we should change the return value of isEnabled in this class

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rohityadavcloud ^


RoleType roleType = accountService.getRoleType(account);
if (isApiAllowed(commandName, roleType)) {
return true;
Expand Down