Skip to content

ui: bump UI pkg version to match CloudStacks#7894

Merged
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:lang-fix
Aug 23, 2023
Merged

ui: bump UI pkg version to match CloudStacks#7894
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:lang-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Aug 22, 2023

This uses the version in UI's package.json same as CloudStack's. The idea is that static assets aren't cached per discussion on #7546

Fixes #7546

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This uses the version in UI's package.json same as CloudStack's. The idea
is that static assets aren't cached per discussion on
apache#7546

Fixes apache#7546

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 22, 2023

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Aug 22, 2023

This could need a manual UI upgrade test; say from 4.18.0 or 4.18 without this PR to this PR/pkgs.

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache linked an issue Aug 22, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2023

Codecov Report

Merging #7894 (e890000) into 4.18 (db0e7a6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7894      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
+ Complexity     9084     9083       -1     
============================================
  Files          2720     2720              
  Lines        257289   257289              
  Branches      40116    40116              
============================================
- Hits          33612    33610       -2     
- Misses       219455   219458       +3     
+ Partials       4222     4221       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6855

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, I'll find a random version to (test) upgrade from

@DaanHoogland DaanHoogland self-assigned this Aug 22, 2023
@DaanHoogland
Copy link
Copy Markdown
Contributor

did an upgrade from 4.17.1 and monkey tested the resulting env. No strangeties encountered. Do you think I should do a more structured test for this @rohityadavcloud @weizhouapache @Others ?

@weizhouapache
Copy link
Copy Markdown
Member

did an upgrade from 4.17.1 and monkey tested the resulting env. No strangeties encountered. Do you think I should do a more structured test for this @rohityadavcloud @weizhouapache @Others ?

fine with me @DaanHoogland

have you verified #7546 ?

@DaanHoogland
Copy link
Copy Markdown
Contributor

have you verified #7546 ?

@weizhouapache I see new strings in comparison to 4.17.1 :
image
if that is what you mean?

@weizhouapache
Copy link
Copy Markdown
Member

have you verified #7546 ?

@weizhouapache I see new strings in comparison to 4.17.1 : image if that is what you mean?

looks good, :+1

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache merged commit b37834f into apache:4.18 Aug 23, 2023
@DaanHoogland DaanHoogland deleted the lang-fix branch August 23, 2023 11:16
DaanHoogland added a commit that referenced this pull request Aug 23, 2023
* 4.18:
  ui: bump UI pkg version to match CloudStacks (#7894)
@DaanHoogland DaanHoogland removed their assignment Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language translation files are cached after upgrade

5 participants