api/utils/ui: List protocol numbers and icmp types by weizhouapache · Pull Request #8293 · apache/cloudstack

weizhouapache · 2023-12-01T11:00:10Z

Description

This PR contains the following changes

adds a new API to list network procotols and details/types/codes, etc
get network protocols on UI and add dropdowns for procotol numbers and icmp types/codes
validate icmp types/codes when add network ACL
etc

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2023-12-01T11:03:21Z

@blueorangutan package

blueorangutan · 2023-12-01T11:04:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2023-12-01T11:28:41Z

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (12dcf5c) 28.95% compared to head (d1b3ff9) 30.84%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
ui/src/views/network/AclListRulesTab.vue	0.00%	28 Missing ⚠️
ui/src/views/network/EgressRulesTab.vue	0.00%	16 Missing ⚠️
ui/src/views/network/FirewallRules.vue	0.00%	16 Missing ⚠️
...i/src/views/network/IngressEgressRuleConfigure.vue	0.00%	16 Missing ⚠️
...oudstack/api/response/NetworkProtocolResponse.java	57.14%	9 Missing ⚠️
...oud/network/security/SecurityGroupManagerImpl.java	0.00%	8 Missing ⚠️
...ain/java/com/cloud/utils/net/NetworkProtocols.java	98.36%	1 Missing and 3 partials ⚠️
.../command/user/network/ListNetworkProtocolsCmd.java	93.93%	1 Missing and 1 partial ⚠️
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java	0.00%	0 Missing and 1 partial ⚠️
...ls/src/main/java/com/cloud/utils/net/NetUtils.java	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8293      +/-   ##
============================================
+ Coverage     28.95%   30.84%   +1.88%     
- Complexity    31460    33916    +2456     
============================================
  Files          5329     5332       +3     
  Lines        373523   373901     +378     
  Branches      54315    54333      +18     
============================================
+ Hits         108163   115322    +7159     
+ Misses       250569   243400    -7169     
- Partials      14791    15179     +388

Flag	Coverage Δ
simulator-marvin-tests	`24.78% <0.31%> (-0.03%)`	⬇️
uitests	`4.41% <0.00%> (-0.02%)`	⬇️
unit-tests	`16.45% <91.82%> (+1.61%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache · 2023-12-01T15:48:14Z

@blueorangutan package

blueorangutan · 2023-12-01T15:50:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-01T16:52:12Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7893

weizhouapache · 2023-12-01T17:26:51Z

@blueorangutan test

blueorangutan · 2023-12-01T17:28:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-02T10:05:43Z

[SF] Trillian test result (tid-8452)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58362 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8293-t8452-kvm-centos7.zip
Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3617.86	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3617.78	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.03	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.03	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.03	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	45.74	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	1.22	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	50.37	test_kubernetes_clusters.py
test_01_verify_ipv6_vpc	`Error`	363.28	test_vpc_ipv6.py

weizhouapache · 2023-12-02T10:24:10Z

@blueorangutan test

blueorangutan · 2023-12-02T10:32:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache · 2023-12-04T07:29:13Z

@blueorangutan package

blueorangutan · 2023-12-04T07:30:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-04T08:31:41Z

Packaging result [SF] ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7905

DaanHoogland · 2023-12-04T08:36:32Z

@blueorangutan test

blueorangutan · 2023-12-04T08:38:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

github-actions · 2023-12-04T09:59:24Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2023-12-04T10:53:59Z

@blueorangutan package

blueorangutan · 2023-12-04T11:02:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-05T00:10:01Z

[SF] Trillian test result (tid-8459)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54420 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8293-t8459-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	`Error`	0.07	test_vm_life_cycle.py

DaanHoogland

code looks good, did a small monkey test on both ui and API but might need more testing mainly in advancedsg zone

weizhouapache · 2023-12-06T15:57:22Z

@blueorangutan package

blueorangutan · 2023-12-06T16:59:13Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7949

DaanHoogland · 2023-12-06T17:35:10Z

@blueorangutan test

blueorangutan · 2023-12-06T17:36:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-07T06:44:43Z

[SF] Trillian test result (tid-8490)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45702 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8293-t8490-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	`Error`	0.06	test_vm_life_cycle.py

kiranchavala · 2023-12-13T12:09:14Z

@blueorangutan package

blueorangutan · 2023-12-13T12:10:03Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-13T13:11:43Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8043

kiranchavala

LGTM, tested the feature manually, with Isolated networks (firewall rules) , VPC (network acl), and security group rules in advanced zone

The dropdowns ( protocols numbers, icmp type and icmp code ) in the UI is working fine

weizhouapache · 2024-01-10T07:41:23Z

this has been tested by @kiranchavala and @alexandremattioli

@shwstppr
ready for merge to main after 4.19.0.0 release

DaanHoogland

clgtm

weizhouapache · 2024-02-02T14:48:28Z

merging based on 2 approvals and manual testing.

This PR contains the following changes * adds a new API to list network procotols and details/types/codes, etc * get network protocols on UI and add dropdowns for procotol numbers and icmp types/codes * validate icmp types/codes when add network ACL

boring-cyborg bot added component:api component:management-server component:networking component:security-group component:UI component:vpc labels Dec 1, 2023

github-actions bot added the status:has-conflicts label Dec 4, 2023

github-actions bot removed the status:has-conflicts label Dec 4, 2023

DaanHoogland approved these changes Dec 5, 2023

View reviewed changes

Comment thread utils/src/main/java/com/cloud/utils/net/NetworkProtocols.java Outdated

weizhouapache added 6 commits December 11, 2023 09:41

api/utils/ui: List protocol numbers and icmp types

8793d24

update 1

4e25ea2

update 2: fix build/test errors in 4.19

c4a57f9

update 3: remove new validation to keep backwards compatibility

699a54a

Update comments

ed8d5f0

Update: fix ui

18c8888

weizhouapache force-pushed the 4.19-list-network-protocols branch from 80e8e20 to 18c8888 Compare December 11, 2023 08:42

weizhouapache added 3 commits December 11, 2023 10:44

Update: add unit tests

1eb972e

Update: add ListNetworkProtocolsCmdTest

34f745f

client/pom.xml: fix code coverage is not updated in some modules

4756ab6

boring-cyborg bot added the component:build label Dec 12, 2023

client/pom.xml: add module cloud-plugin-storage-volume-adaptive

d1b3ff9

kiranchavala approved these changes Dec 19, 2023

View reviewed changes

weizhouapache marked this pull request as ready for review January 10, 2024 07:41

DaanHoogland approved these changes Jan 10, 2024

View reviewed changes

weizhouapache added this to the 4.20.0.0 milestone Jan 18, 2024

weizhouapache mentioned this pull request Feb 1, 2024

UI struggles with ICMP entries in VPC ACLs #8583

Closed

weizhouapache merged commit af8a582 into apache:main Feb 2, 2024

weizhouapache deleted the 4.19-list-network-protocols branch February 2, 2024 15:02

weizhouapache mentioned this pull request Feb 2, 2024

Normalize loggers and upgrade log4j 1.2 to log4j 2.19 #7131

Merged

12 tasks

Conversation

weizhouapache commented Dec 1, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Dec 1, 2023

Uh oh!

blueorangutan commented Dec 1, 2023

Uh oh!

codecov bot commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Dec 1, 2023

Uh oh!

blueorangutan commented Dec 1, 2023

Uh oh!

blueorangutan commented Dec 1, 2023

Uh oh!

weizhouapache commented Dec 1, 2023

Uh oh!

blueorangutan commented Dec 1, 2023

Uh oh!

blueorangutan commented Dec 2, 2023

Uh oh!

weizhouapache commented Dec 2, 2023

Uh oh!

blueorangutan commented Dec 2, 2023

Uh oh!

weizhouapache commented Dec 4, 2023

Uh oh!

blueorangutan commented Dec 4, 2023

Uh oh!

blueorangutan commented Dec 4, 2023 • edited by weizhouapache Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Dec 4, 2023

Uh oh!

blueorangutan commented Dec 4, 2023

Uh oh!

github-actions bot commented Dec 4, 2023

Uh oh!

weizhouapache commented Dec 4, 2023

Uh oh!

blueorangutan commented Dec 4, 2023

Uh oh!

blueorangutan commented Dec 5, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weizhouapache commented Dec 6, 2023

Uh oh!

blueorangutan commented Dec 6, 2023

Uh oh!

DaanHoogland commented Dec 6, 2023

Uh oh!

blueorangutan commented Dec 6, 2023

Uh oh!

blueorangutan commented Dec 7, 2023

Uh oh!

kiranchavala commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jan 10, 2024

Uh oh!

DaanHoogland left a comment

codecov bot commented Dec 1, 2023 •

edited

Loading

blueorangutan commented Dec 4, 2023 •

edited by weizhouapache

Loading