Hypervisor as class by vishesh92 · Pull Request #8798 · apache/cloudstack

vishesh92 · 2024-03-18T14:28:05Z

Description

This PR moves HypervisorType from an Enum to a class that is largely compatible with Enum. This will allow for custom hypervisor plugins to be added dynamically.

The changes are similar to what was done for StorageType in #8544.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-03-18T14:37:07Z

Codecov Report

Attention: Patch coverage is 28.65169% with 127 lines in your changes are missing coverage. Please review.

Project coverage is 31.09%. Comparing base (33dc746) to head (e227f51).

Files	Patch %	Lines
.../main/java/com/cloud/network/NetworkModelImpl.java	0.00%	30 Missing and 10 partials ⚠️
...ava/com/cloud/upgrade/dao/Upgrade41500to41510.java	0.00%	37 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	10 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	8 Missing ⚠️
...src/main/java/com/cloud/hypervisor/Hypervisor.java	82.92%	3 Missing and 4 partials ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java	0.00%	6 Missing ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java	0.00%	6 Missing ⚠️
...he/cloudstack/transport/HypervisorTypeAdaptor.java	37.50%	4 Missing and 1 partial ⚠️
...va/com/cloud/network/ovs/OvsTunnelManagerImpl.java	0.00%	5 Missing ⚠️
...om/cloud/upgrade/SystemVmTemplateRegistration.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8798      +/-   ##
============================================
+ Coverage     31.04%   31.09%   +0.05%     
- Complexity    33898    33958      +60     
============================================
  Files          5404     5406       +2     
  Lines        380278   380295      +17     
  Branches      55504    55544      +40     
============================================
+ Hits         118053   118250     +197     
+ Misses       246485   246332     -153     
+ Partials      15740    15713      -27

Flag	Coverage Δ
simulator-marvin-tests	`24.69% <25.84%> (+0.07%)`	⬆️
uitests	`4.34% <ø> (ø)`
unit-tests	`16.88% <21.34%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 · 2024-03-18T17:56:59Z

@blueorangutan package

blueorangutan · 2024-03-18T17:58:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92 · 2024-03-18T19:02:49Z

@blueorangutan package

blueorangutan · 2024-03-18T19:04:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-18T20:07:40Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8965

vishesh92 · 2024-03-18T20:32:03Z

@blueorangutan test matrix

blueorangutan · 2024-03-18T20:34:03Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-19T09:08:09Z

[SF] Trillian test result (tid-9520)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43749 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9520-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-19T11:43:28Z

[SF] Trillian test result (tid-9521)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9521-vmware-67u3.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	135.87	test_cluster_drs.py

github-actions · 2024-03-19T12:13:04Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

vishesh92 · 2024-03-19T12:20:26Z

@blueorangutan package

blueorangutan · 2024-03-19T12:22:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-19T12:28:57Z

[SF] Trillian test result (tid-9522)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55617 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9522-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-19T13:30:10Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8971

vishesh92 · 2024-03-19T13:46:18Z

@blueorangutan test matrix

blueorangutan · 2024-03-19T13:48:06Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-20T02:27:40Z

[SF] Trillian test result (tid-9528)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43959 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9528-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-20T02:58:42Z

[SF] Trillian test result (tid-9526)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9526-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-20T04:23:51Z

[SF] Trillian test result (tid-9527)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8798-t9527-vmware-67u3.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Error`	423.29	test_cluster_drs.py

sureshanaparti

Code LGTM

yadvr · 2024-04-02T12:06:10Z

Merging based on code reviews and manual QA as nudged by @borisstoyanov to me.

borisstoyanov

LGTM

* HypervisorType as a class * Fixup * fixup * Add missing annotation * Resolve comments * Handle parallels typo * Add missing @convert annotation

vishesh92 added 6 commits March 18, 2024 19:04

HypervisorType as a class

39c7abb

Fixup

8cbc554

fixup

5383687

Add missing annotation

2dddd31

Resolve comments

2f1dbad

Handle parallels typo

5c3f731

boring-cyborg bot added component:api component:compute component:database component:networking component:orchestration component:storage labels Mar 18, 2024

apache deleted a comment from blueorangutan Mar 18, 2024

Add missing @convert annotation

6a24901

apache deleted a comment from blueorangutan Mar 18, 2024

github-actions bot added the status:has-conflicts label Mar 19, 2024

Merge branch 'main' into hypervisor-as-class

e227f51

github-actions bot removed the status:has-conflicts label Mar 19, 2024

sureshanaparti approved these changes Mar 21, 2024

View reviewed changes

vishesh92 marked this pull request as ready for review March 28, 2024 06:58

yadvr added this to the 4.20.0.0 milestone Apr 2, 2024

yadvr approved these changes Apr 2, 2024

View reviewed changes

yadvr merged commit 93f3182 into apache:main Apr 2, 2024

yadvr deleted the hypervisor-as-class branch April 2, 2024 12:06

borisstoyanov reviewed Apr 2, 2024

View reviewed changes

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Apr 9, 2024

Hypervisor as class (apache#8798)

bd9e159

* HypervisorType as a class * Fixup * fixup * Add missing annotation * Resolve comments * Handle parallels typo * Add missing @convert annotation

Conversation

vishesh92 commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 commented Mar 18, 2024

Uh oh!

blueorangutan commented Mar 18, 2024

Uh oh!

vishesh92 commented Mar 18, 2024

Uh oh!

blueorangutan commented Mar 18, 2024

Uh oh!

blueorangutan commented Mar 18, 2024

Uh oh!

vishesh92 commented Mar 18, 2024

Uh oh!

blueorangutan commented Mar 18, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

github-actions bot commented Mar 19, 2024

Uh oh!

vishesh92 commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

vishesh92 commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 19, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Apr 2, 2024

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vishesh92 commented Mar 18, 2024 •

edited

Loading

codecov bot commented Mar 18, 2024 •

edited

Loading