Skip to content

Commit 5824eae

Browse files
committed
Reduce vertical whitespace
1 parent c54a16d commit 5824eae

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

src/conf/spotbugs-exclude-filter.xml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,32 +24,28 @@
2424
<FindBugsFilter
2525
xmlns="https://github.com/spotbugs/filter/3.0.0"
2626
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
27-
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"><!-- Using wild-card class names so exclusions work regardless of the top-level package -->
28-
27+
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
28+
<!-- Using wild-card class names so exclusions work regardless of the top-level package -->
2929
<!-- https://github.com/spotbugs/spotbugs/issues/2710 -->
3030
<Match>
3131
<Class name="~.*" />
3232
<Bug pattern="CT_CONSTRUCTOR_THROW" />
3333
</Match>
34-
3534
<!-- Waiting on BCEL-252 -->
3635
<Match>
3736
<Class name="~.*\.util\.Class2HTML" />
3837
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
3938
</Match>
40-
4139
<!-- Class is not supposed to be an Exception itself -->
4240
<Match>
4341
<Class name="~.*\.classfile\.CodeException" />
4442
<Bug pattern="NM_CLASS_NOT_EXCEPTION" />
4543
</Match>
46-
4744
<!-- Ignore GC here -->
4845
<Match>
4946
<Class name="~.*\.verifier\.TransitiveHull" />
5047
<Bug pattern="DM_GC" />
5148
</Match>
52-
5349
<!-- clone() creates a new instance so does not need to call super.clone() -->
5450
<Match>
5551
<Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
@@ -59,7 +55,6 @@
5955
<Class name="~.*\.verifier\.structurals\.OperandStack"/>
6056
</Or>
6157
</Match>
62-
6358
<!-- Binary compatibility -->
6459
<Match>
6560
<Class name="org.apache.bcel.Repository"/>
@@ -78,7 +73,6 @@
7873
<Field name="IGNORED"/>
7974
<Bug pattern="MS_PKGPROTECT"/>
8075
</Match>
81-
8276
<!--
8377
TODO: this should probably be sinplified
8478
Medium: Complicated, subtle or wrong increment in for-loop
@@ -91,7 +85,6 @@
9185
<Method name="printFlags" params="int, org.apache.bcel.util.BCELifier$FLAGS" returns="java.lang.String"/>
9286
<Bug pattern="QF_QUESTIONABLE_FOR_LOOP"/>
9387
</Match>
94-
9588
<!-- Reason: TODO, perhaps? -->
9689
<Match>
9790
<Class name="~.*" />
@@ -100,21 +93,18 @@
10093
<Bug pattern="EI_EXPOSE_REP2" />
10194
</Or>
10295
</Match>
103-
10496
<!-- TODO - enable later -->
10597
<Match>
10698
<Class name="~.*" />
10799
<Bug pattern="MS_MUTABLE_ARRAY" />
108100
</Match>
109-
110101
<!-- Test data classes -->
111102
<Match>
112103
<Or>
113104
<Class name="~.*\.data\..*" />
114105
<Class name="~.*\.tests\.Test.*" />
115106
</Or>
116107
</Match>
117-
118108
<!--
119109
This is intentional
120110
Error: Switch statement found in org.apache.bcel.util.BCELFactory.visitAllocationInstruction(AllocationInstruction)
@@ -128,7 +118,6 @@
128118
<Method name="visitAllocationInstruction"/>
129119
<Bug pattern="SF_SWITCH_FALLTHROUGH"/>
130120
</Match>
131-
132121
<!--
133122
Class is deprecated
134123
Error: The class name org.apache.bcel.util.ClassLoader
@@ -146,7 +135,6 @@
146135
<Bug pattern="MS_PKGPROTECT"/>
147136
</Or>
148137
</Match>
149-
150138
<!--
151139
TODO: field is deprecated in preparation for making it private later
152140
Error: org.apache.bcel.verifier.structurals.Frame._this should be package protected
@@ -158,7 +146,6 @@
158146
<Field name="_this"/>
159147
<Bug pattern="MS_PKGPROTECT"/>
160148
</Match>
161-
162149
<!-- TODO Is this really identity equality and not object equality? -->
163150
<Match>
164151
<Class name="Mini.ASTFunDecl"/>
@@ -170,7 +157,6 @@
170157
<Class name="Mini.Environment"/>
171158
<Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
172159
</Match>
173-
174160
<!-- Skip JavaCC generated code. -->
175161
<Match>
176162
<Class name="Mini.MiniParser"/>

0 commit comments

Comments
 (0)