|
24 | 24 | <FindBugsFilter |
25 | 25 | xmlns="https://github.com/spotbugs/filter/3.0.0" |
26 | 26 | xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
27 | | - xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"><!-- Using wild-card class names so exclusions work regardless of the top-level package --> |
28 | | - |
| 27 | + xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"> |
| 28 | + <!-- Using wild-card class names so exclusions work regardless of the top-level package --> |
29 | 29 | <!-- https://github.com/spotbugs/spotbugs/issues/2710 --> |
30 | 30 | <Match> |
31 | 31 | <Class name="~.*" /> |
32 | 32 | <Bug pattern="CT_CONSTRUCTOR_THROW" /> |
33 | 33 | </Match> |
34 | | - |
35 | 34 | <!-- Waiting on BCEL-252 --> |
36 | 35 | <Match> |
37 | 36 | <Class name="~.*\.util\.Class2HTML" /> |
38 | 37 | <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" /> |
39 | 38 | </Match> |
40 | | - |
41 | 39 | <!-- Class is not supposed to be an Exception itself --> |
42 | 40 | <Match> |
43 | 41 | <Class name="~.*\.classfile\.CodeException" /> |
44 | 42 | <Bug pattern="NM_CLASS_NOT_EXCEPTION" /> |
45 | 43 | </Match> |
46 | | - |
47 | 44 | <!-- Ignore GC here --> |
48 | 45 | <Match> |
49 | 46 | <Class name="~.*\.verifier\.TransitiveHull" /> |
50 | 47 | <Bug pattern="DM_GC" /> |
51 | 48 | </Match> |
52 | | - |
53 | 49 | <!-- clone() creates a new instance so does not need to call super.clone() --> |
54 | 50 | <Match> |
55 | 51 | <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/> |
|
59 | 55 | <Class name="~.*\.verifier\.structurals\.OperandStack"/> |
60 | 56 | </Or> |
61 | 57 | </Match> |
62 | | - |
63 | 58 | <!-- Binary compatibility --> |
64 | 59 | <Match> |
65 | 60 | <Class name="org.apache.bcel.Repository"/> |
|
78 | 73 | <Field name="IGNORED"/> |
79 | 74 | <Bug pattern="MS_PKGPROTECT"/> |
80 | 75 | </Match> |
81 | | - |
82 | 76 | <!-- |
83 | 77 | TODO: this should probably be sinplified |
84 | 78 | Medium: Complicated, subtle or wrong increment in for-loop |
|
91 | 85 | <Method name="printFlags" params="int, org.apache.bcel.util.BCELifier$FLAGS" returns="java.lang.String"/> |
92 | 86 | <Bug pattern="QF_QUESTIONABLE_FOR_LOOP"/> |
93 | 87 | </Match> |
94 | | - |
95 | 88 | <!-- Reason: TODO, perhaps? --> |
96 | 89 | <Match> |
97 | 90 | <Class name="~.*" /> |
|
100 | 93 | <Bug pattern="EI_EXPOSE_REP2" /> |
101 | 94 | </Or> |
102 | 95 | </Match> |
103 | | - |
104 | 96 | <!-- TODO - enable later --> |
105 | 97 | <Match> |
106 | 98 | <Class name="~.*" /> |
107 | 99 | <Bug pattern="MS_MUTABLE_ARRAY" /> |
108 | 100 | </Match> |
109 | | - |
110 | 101 | <!-- Test data classes --> |
111 | 102 | <Match> |
112 | 103 | <Or> |
113 | 104 | <Class name="~.*\.data\..*" /> |
114 | 105 | <Class name="~.*\.tests\.Test.*" /> |
115 | 106 | </Or> |
116 | 107 | </Match> |
117 | | - |
118 | 108 | <!-- |
119 | 109 | This is intentional |
120 | 110 | Error: Switch statement found in org.apache.bcel.util.BCELFactory.visitAllocationInstruction(AllocationInstruction) |
|
128 | 118 | <Method name="visitAllocationInstruction"/> |
129 | 119 | <Bug pattern="SF_SWITCH_FALLTHROUGH"/> |
130 | 120 | </Match> |
131 | | - |
132 | 121 | <!-- |
133 | 122 | Class is deprecated |
134 | 123 | Error: The class name org.apache.bcel.util.ClassLoader |
|
146 | 135 | <Bug pattern="MS_PKGPROTECT"/> |
147 | 136 | </Or> |
148 | 137 | </Match> |
149 | | - |
150 | 138 | <!-- |
151 | 139 | TODO: field is deprecated in preparation for making it private later |
152 | 140 | Error: org.apache.bcel.verifier.structurals.Frame._this should be package protected |
|
158 | 146 | <Field name="_this"/> |
159 | 147 | <Bug pattern="MS_PKGPROTECT"/> |
160 | 148 | </Match> |
161 | | - |
162 | 149 | <!-- TODO Is this really identity equality and not object equality? --> |
163 | 150 | <Match> |
164 | 151 | <Class name="Mini.ASTFunDecl"/> |
|
170 | 157 | <Class name="Mini.Environment"/> |
171 | 158 | <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/> |
172 | 159 | </Match> |
173 | | - |
174 | 160 | <!-- Skip JavaCC generated code. --> |
175 | 161 | <Match> |
176 | 162 | <Class name="Mini.MiniParser"/> |
|
0 commit comments