No need to end exception messages with an exclamation!

garydgregory · garydgregory · commit 71ebcd237a41 · 2026-04-15T07:58:39.000-04:00
diff --git a/src/main/java/org/apache/bcel/classfile/Utility.java b/src/main/java/org/apache/bcel/classfile/Utility.java
@@ -561,7 +561,7 @@ public static String codeToString(final ByteSequence bytes, final ConstantPool c
                         buf.append(bytes.readInt());
                         break;
                     default: // Never reached
-                        throw new IllegalStateException("Unreachable default case reached!");
+                        throw new IllegalStateException("Unreachable default case reached.");
                     }
                 }
             }
diff --git a/src/main/java/org/apache/bcel/generic/FieldGen.java b/src/main/java/org/apache/bcel/generic/FieldGen.java
@@ -164,7 +164,7 @@ private void checkType(final Type atype) {
             throw new ClassGenException("You haven't defined the type of the field yet");
         }
         if (!isFinal()) {
-            throw new ClassGenException("Only final fields may have an initial value!");
+            throw new ClassGenException("Only final fields may have an initial value.");
         }
         if (!superType.equals(atype)) {
             throw new ClassGenException("Types are not compatible: " + superType + " vs. " + atype);
diff --git a/src/main/java/org/apache/bcel/verifier/statics/Pass2Verifier.java b/src/main/java/org/apache/bcel/verifier/statics/Pass2Verifier.java
@@ -581,13 +581,13 @@ public void visitField(final Field obj) {
                 }
             } else { // isInterface!
                 if (!obj.isPublic()) {
-                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't!");
+                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't.");
                 }
                 if (!obj.isStatic()) {
-                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_STATIC modifier set but hasn't!");
+                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_STATIC modifier set but hasn't.");
                 }
                 if (!obj.isFinal()) {
-                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_FINAL modifier set but hasn't!");
+                    throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_FINAL modifier set but hasn't.");
                 }
             }
 
@@ -617,7 +617,7 @@ public void visitField(final Field obj) {
 
             final String nameanddesc = name + sig;
             if (fieldNamesAndDesc.contains(nameanddesc)) {
-                throw new ClassConstraintException("No two fields (like '" + tostring(obj) + "') are allowed have same names and descriptors!");
+                throw new ClassConstraintException("No two fields (like '" + tostring(obj) + "') are allowed have same names and descriptors.");
             }
             if (fieldNames.contains(name)) {
                 addMessage("More than one field of name '" + name + "' detected (but with different type descriptors). This is very unusual.");
@@ -897,10 +897,10 @@ public void visitMethod(final Method obj) {
 
                 } else {
                     if (!obj.isPublic()) {
-                        throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't!");
+                        throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't.");
                     }
                     if (!obj.isAbstract()) {
-                        throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_ABSTRACT modifier set but hasn't!");
+                        throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_ABSTRACT modifier set but hasn't.");
                     }
                     if (obj.isPrivate() || obj.isProtected() || obj.isStatic() || obj.isFinal() || obj.isSynchronized() || obj.isNative() || obj.isStrictfp()) {
                         throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must not have"
@@ -918,7 +918,7 @@ public void visitMethod(final Method obj) {
 
             final String nameanddesc = name + sig;
             if (methodNamesAndDesc.contains(nameanddesc)) {
-                throw new ClassConstraintException("No two methods (like '" + tostring(obj) + "') are allowed have same names and desciptors!");
+                throw new ClassConstraintException("No two methods (like '" + tostring(obj) + "') are allowed have same names and desciptors.");
             }
             methodNamesAndDesc.add(nameanddesc);
 
@@ -1015,7 +1015,7 @@ private FAMRAV_Visitor(final JavaClass jc) {
         @Override
         public void visitConstantFieldref(final ConstantFieldref obj) {
             if (obj.getTag() != Const.CONSTANT_Fieldref) {
-                throw new ClassConstraintException("ConstantFieldref '" + tostring(obj) + "' has wrong tag!");
+                throw new ClassConstraintException("ConstantFieldref '" + tostring(obj) + "' has wrong tag.");
             }
             final int nameAndTypeIndex = obj.getNameAndTypeIndex();
             final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);
@@ -1043,7 +1043,7 @@ public void visitConstantFieldref(final ConstantFieldref obj) {
         @Override
         public void visitConstantInterfaceMethodref(final ConstantInterfaceMethodref obj) {
             if (obj.getTag() != Const.CONSTANT_InterfaceMethodref) {
-                throw new ClassConstraintException("ConstantInterfaceMethodref '" + tostring(obj) + "' has wrong tag!");
+                throw new ClassConstraintException("ConstantInterfaceMethodref '" + tostring(obj) + "' has wrong tag.");
             }
             final int nameAndTypeIndex = obj.getNameAndTypeIndex();
             final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);
@@ -1076,7 +1076,7 @@ public void visitConstantInterfaceMethodref(final ConstantInterfaceMethodref obj
         @Override
         public void visitConstantMethodref(final ConstantMethodref obj) {
             if (obj.getTag() != Const.CONSTANT_Methodref) {
-                throw new ClassConstraintException("ConstantMethodref '" + tostring(obj) + "' has wrong tag!");
+                throw new ClassConstraintException("ConstantMethodref '" + tostring(obj) + "' has wrong tag.");
             }
             final int nameAndTypeIndex = obj.getNameAndTypeIndex();
             final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);
diff --git a/src/main/java/org/apache/bcel/verifier/statics/Pass3aVerifier.java b/src/main/java/org/apache/bcel/verifier/statics/Pass3aVerifier.java
@@ -1021,7 +1021,7 @@ public VerificationResult do_verify() {
                 final JavaClass jc = Repository.lookupClass(verifier.getClassName());
                 final Method[] methods = jc.getMethods();
                 if (methodNo >= methods.length) {
-                    throw new InvalidMethodException("METHOD DOES NOT EXIST!");
+                    throw new InvalidMethodException("METHOD DOES NOT EXIST.");
                 }
                 final Method method = methods[methodNo];
                 code = method.getCode();
@@ -1120,13 +1120,13 @@ private void pass3StaticInstructionChecks() {
         while (ih != null) {
             final Instruction i = ih.getInstruction();
             if (i instanceof IMPDEP1) {
-                throw new StaticCodeInstructionConstraintException("IMPDEP1 must not be in the code, it is an illegal instruction for _internal_ JVM use!");
+                throw new StaticCodeInstructionConstraintException("IMPDEP1 must not be in the code, it is an illegal instruction for _internal_ JVM use.");
             }
             if (i instanceof IMPDEP2) {
-                throw new StaticCodeInstructionConstraintException("IMPDEP2 must not be in the code, it is an illegal instruction for _internal_ JVM use!");
+                throw new StaticCodeInstructionConstraintException("IMPDEP2 must not be in the code, it is an illegal instruction for _internal_ JVM use.");
             }
             if (i instanceof BREAKPOINT) {
-                throw new StaticCodeInstructionConstraintException("BREAKPOINT must not be in the code, it is an illegal instruction for _internal_ JVM use!");
+                throw new StaticCodeInstructionConstraintException("BREAKPOINT must not be in the code, it is an illegal instruction for _internal_ JVM use.");
             }
             ih = ih.getNext();
         }
diff --git a/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java b/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java
@@ -104,7 +104,7 @@ private InstructionHandle[] _getSuccessors() {
                 final Subroutine s = subroutines.subroutineOf(getInstruction());
                 if (s == null) { // return empty;
                     // RET in dead code. "empty" would be the correct answer, but we know something about the surrounding project...
-                    throw new AssertionViolatedException("Asking for successors of a RET in dead code?!");
+                    throw new AssertionViolatedException("Asking for successors of a RET in dead code?.");
                 }
 
 //TODO: remove. Only JustIce must not use it, but foreign users of the ControlFlowGraph
@@ -398,7 +398,7 @@ public ControlFlowGraph(final MethodGen methodGen, final boolean enableJustIceCh
     public InstructionContext contextOf(final InstructionHandle inst) {
         final InstructionContext ic = instructionContexts.get(inst);
         if (ic == null) {
-            throw new AssertionViolatedException("InstructionContext requested for an InstructionHandle that's not known!");
+            throw new AssertionViolatedException("InstructionContext requested for an InstructionHandle that's not known.");
         }
         return ic;
     }
diff --git a/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java b/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java
@@ -459,7 +459,7 @@ public void visitCHECKCAST(final CHECKCAST o) {
     public void visitCPInstruction(final CPInstruction o) {
         final int idx = o.getIndex();
         if (idx < 0 || idx >= cpg.getSize()) {
-            throw new AssertionViolatedException("Huh?! Constant pool index of instruction '" + o + "' illegal? Pass 3a should have checked this!");
+            throw new AssertionViolatedException("Huh?! Constant pool index of instruction '" + o + "' illegal? Pass 3a should have checked this.");
         }
     }
 
@@ -2360,7 +2360,7 @@ public void visitNEW(final NEW o) {
 
         final Type t = o.getType(cpg);
         if (!(t instanceof ReferenceType)) {
-            throw new AssertionViolatedException("NEW.getType() returning a non-reference type?!");
+            throw new AssertionViolatedException("NEW.getType() returning a non-reference type?.");
         }
         if (!(t instanceof ObjectType)) {
             constraintViolated(o, "Expecting a class type (ObjectType) to work on. Found: '" + t + "'.");
@@ -2484,7 +2484,7 @@ public void visitRET(final RET o) {
             constraintViolated(o, "Expecting a ReturnaddressType in local variable " + o.getIndex() + ".");
         }
         if (locals().get(o.getIndex()) == ReturnaddressType.NO_TARGET) {
-            throw new AssertionViolatedException("RET expecting a target!");
+            throw new AssertionViolatedException("RET expecting a target.");
         }
         // Other constraints such as non-allowed overlapping subroutines are enforced
         // while building the Subroutines data structure.
diff --git a/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java b/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java
@@ -206,7 +206,7 @@ private void circulationPump(final MethodGen m, final ControlFlowGraph cfg, fina
                 int skipJsr = 0;
                 for (int ss = oldchain.size() - 1; ss >= 0; ss--) {
                     if (skipJsr < 0) {
-                        throw new AssertionViolatedException("More RET than JSR in execution chain?!");
+                        throw new AssertionViolatedException("More RET than JSR in execution chain?.");
                     }
 //System.err.println("+"+oldchain.get(ss));
                     if (oldchain.get(ss).getInstruction().getInstruction() instanceof JsrInstruction) {
diff --git a/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java b/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
@@ -110,7 +110,7 @@ public void addEnteringJsrInstruction(final InstructionHandle jsrInst) {
                 throw new AssertionViolatedException("Expecting JsrInstruction InstructionHandle.");
             }
             if (localVariable == UNSET) {
-                throw new AssertionViolatedException("Set the localVariable first!");
+                throw new AssertionViolatedException("Set the localVariable first.");
             }
             // Something is wrong when an ASTORE is targeted that does not operate on the same local variable than the rest of the
             // JsrInstruction-targets and the RET.

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ public static String codeToString(final ByteSequence bytes, final ConstantPool c`
`561`	`561`	`buf.append(bytes.readInt());`
`562`	`562`	`break;`
`563`	`563`	`default: // Never reached`
`564`		`- throw new IllegalStateException("Unreachable default case reached!");`
	`564`	`+ throw new IllegalStateException("Unreachable default case reached.");`
`565`	`565`	`}`
`566`	`566`	`}`
`567`	`567`	`}`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ private void checkType(final Type atype) {`
`164`	`164`	`throw new ClassGenException("You haven't defined the type of the field yet");`
`165`	`165`	`}`
`166`	`166`	`if (!isFinal()) {`
`167`		`- throw new ClassGenException("Only final fields may have an initial value!");`
	`167`	`+ throw new ClassGenException("Only final fields may have an initial value.");`
`168`	`168`	`}`
`169`	`169`	`if (!superType.equals(atype)) {`
`170`	`170`	`throw new ClassGenException("Types are not compatible: " + superType + " vs. " + atype);`
Original file line number	Diff line number	Diff line change
`@@ -581,13 +581,13 @@ public void visitField(final Field obj) {`
`581`	`581`	`}`
`582`	`582`	`} else { // isInterface!`
`583`	`583`	`if (!obj.isPublic()) {`
`584`		`- throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't!");`
	`584`	`+ throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't.");`
`585`	`585`	`}`
`586`	`586`	`if (!obj.isStatic()) {`
`587`		`- throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_STATIC modifier set but hasn't!");`
	`587`	`+ throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_STATIC modifier set but hasn't.");`
`588`	`588`	`}`
`589`	`589`	`if (!obj.isFinal()) {`
`590`		`- throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_FINAL modifier set but hasn't!");`
	`590`	`+ throw new ClassConstraintException("Interface field '" + tostring(obj) + "' must have the ACC_FINAL modifier set but hasn't.");`
`591`	`591`	`}`
`592`	`592`	`}`
`593`	`593`
`@@ -617,7 +617,7 @@ public void visitField(final Field obj) {`
`617`	`617`
`618`	`618`	`final String nameanddesc = name + sig;`
`619`	`619`	`if (fieldNamesAndDesc.contains(nameanddesc)) {`
`620`		`- throw new ClassConstraintException("No two fields (like '" + tostring(obj) + "') are allowed have same names and descriptors!");`
	`620`	`+ throw new ClassConstraintException("No two fields (like '" + tostring(obj) + "') are allowed have same names and descriptors.");`
`621`	`621`	`}`
`622`	`622`	`if (fieldNames.contains(name)) {`
`623`	`623`	`addMessage("More than one field of name '" + name + "' detected (but with different type descriptors). This is very unusual.");`
`@@ -897,10 +897,10 @@ public void visitMethod(final Method obj) {`
`897`	`897`
`898`	`898`	`} else {`
`899`	`899`	`if (!obj.isPublic()) {`
`900`		`- throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't!");`
	`900`	`+ throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_PUBLIC modifier set but hasn't.");`
`901`	`901`	`}`
`902`	`902`	`if (!obj.isAbstract()) {`
`903`		`- throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_ABSTRACT modifier set but hasn't!");`
	`903`	`+ throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must have the ACC_ABSTRACT modifier set but hasn't.");`
`904`	`904`	`}`
`905`	`905`	`if (obj.isPrivate() \|\| obj.isProtected() \|\| obj.isStatic() \|\| obj.isFinal() \|\| obj.isSynchronized() \|\| obj.isNative() \|\| obj.isStrictfp()) {`
`906`	`906`	`throw new ClassConstraintException("Interface method '" + tostring(obj) + "' must not have"`
`@@ -918,7 +918,7 @@ public void visitMethod(final Method obj) {`
`918`	`918`
`919`	`919`	`final String nameanddesc = name + sig;`
`920`	`920`	`if (methodNamesAndDesc.contains(nameanddesc)) {`
`921`		`- throw new ClassConstraintException("No two methods (like '" + tostring(obj) + "') are allowed have same names and desciptors!");`
	`921`	`+ throw new ClassConstraintException("No two methods (like '" + tostring(obj) + "') are allowed have same names and desciptors.");`
`922`	`922`	`}`
`923`	`923`	`methodNamesAndDesc.add(nameanddesc);`
`924`	`924`
`@@ -1015,7 +1015,7 @@ private FAMRAV_Visitor(final JavaClass jc) {`
`1015`	`1015`	`@Override`
`1016`	`1016`	`public void visitConstantFieldref(final ConstantFieldref obj) {`
`1017`	`1017`	`if (obj.getTag() != Const.CONSTANT_Fieldref) {`
`1018`		`- throw new ClassConstraintException("ConstantFieldref '" + tostring(obj) + "' has wrong tag!");`
	`1018`	`+ throw new ClassConstraintException("ConstantFieldref '" + tostring(obj) + "' has wrong tag.");`
`1019`	`1019`	`}`
`1020`	`1020`	`final int nameAndTypeIndex = obj.getNameAndTypeIndex();`
`1021`	`1021`	`final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);`
`@@ -1043,7 +1043,7 @@ public void visitConstantFieldref(final ConstantFieldref obj) {`
`1043`	`1043`	`@Override`
`1044`	`1044`	`public void visitConstantInterfaceMethodref(final ConstantInterfaceMethodref obj) {`
`1045`	`1045`	`if (obj.getTag() != Const.CONSTANT_InterfaceMethodref) {`
`1046`		`- throw new ClassConstraintException("ConstantInterfaceMethodref '" + tostring(obj) + "' has wrong tag!");`
	`1046`	`+ throw new ClassConstraintException("ConstantInterfaceMethodref '" + tostring(obj) + "' has wrong tag.");`
`1047`	`1047`	`}`
`1048`	`1048`	`final int nameAndTypeIndex = obj.getNameAndTypeIndex();`
`1049`	`1049`	`final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);`
`@@ -1076,7 +1076,7 @@ public void visitConstantInterfaceMethodref(final ConstantInterfaceMethodref obj`
`1076`	`1076`	`@Override`
`1077`	`1077`	`public void visitConstantMethodref(final ConstantMethodref obj) {`
`1078`	`1078`	`if (obj.getTag() != Const.CONSTANT_Methodref) {`
`1079`		`- throw new ClassConstraintException("ConstantMethodref '" + tostring(obj) + "' has wrong tag!");`
	`1079`	`+ throw new ClassConstraintException("ConstantMethodref '" + tostring(obj) + "' has wrong tag.");`
`1080`	`1080`	`}`
`1081`	`1081`	`final int nameAndTypeIndex = obj.getNameAndTypeIndex();`
`1082`	`1082`	`final ConstantNameAndType cnat = (ConstantNameAndType) cp.getConstant(nameAndTypeIndex);`
Original file line number	Diff line number	Diff line change
`@@ -1021,7 +1021,7 @@ public VerificationResult do_verify() {`
`1021`	`1021`	`final JavaClass jc = Repository.lookupClass(verifier.getClassName());`
`1022`	`1022`	`final Method[] methods = jc.getMethods();`
`1023`	`1023`	`if (methodNo >= methods.length) {`
`1024`		`- throw new InvalidMethodException("METHOD DOES NOT EXIST!");`
	`1024`	`+ throw new InvalidMethodException("METHOD DOES NOT EXIST.");`
`1025`	`1025`	`}`
`1026`	`1026`	`final Method method = methods[methodNo];`
`1027`	`1027`	`code = method.getCode();`
`@@ -1120,13 +1120,13 @@ private void pass3StaticInstructionChecks() {`
`1120`	`1120`	`while (ih != null) {`
`1121`	`1121`	`final Instruction i = ih.getInstruction();`
`1122`	`1122`	`if (i instanceof IMPDEP1) {`
`1123`		`- throw new StaticCodeInstructionConstraintException("IMPDEP1 must not be in the code, it is an illegal instruction for _internal_ JVM use!");`
	`1123`	`+ throw new StaticCodeInstructionConstraintException("IMPDEP1 must not be in the code, it is an illegal instruction for _internal_ JVM use.");`
`1124`	`1124`	`}`
`1125`	`1125`	`if (i instanceof IMPDEP2) {`
`1126`		`- throw new StaticCodeInstructionConstraintException("IMPDEP2 must not be in the code, it is an illegal instruction for _internal_ JVM use!");`
	`1126`	`+ throw new StaticCodeInstructionConstraintException("IMPDEP2 must not be in the code, it is an illegal instruction for _internal_ JVM use.");`
`1127`	`1127`	`}`
`1128`	`1128`	`if (i instanceof BREAKPOINT) {`
`1129`		`- throw new StaticCodeInstructionConstraintException("BREAKPOINT must not be in the code, it is an illegal instruction for _internal_ JVM use!");`
	`1129`	`+ throw new StaticCodeInstructionConstraintException("BREAKPOINT must not be in the code, it is an illegal instruction for _internal_ JVM use.");`
`1130`	`1130`	`}`
`1131`	`1131`	`ih = ih.getNext();`
`1132`	`1132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ private InstructionHandle[] _getSuccessors() {`
`104`	`104`	`final Subroutine s = subroutines.subroutineOf(getInstruction());`
`105`	`105`	`if (s == null) { // return empty;`
`106`	`106`	`// RET in dead code. "empty" would be the correct answer, but we know something about the surrounding project...`
`107`		`- throw new AssertionViolatedException("Asking for successors of a RET in dead code?!");`
	`107`	`+ throw new AssertionViolatedException("Asking for successors of a RET in dead code?.");`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`//TODO: remove. Only JustIce must not use it, but foreign users of the ControlFlowGraph`
`@@ -398,7 +398,7 @@ public ControlFlowGraph(final MethodGen methodGen, final boolean enableJustIceCh`
`398`	`398`	`public InstructionContext contextOf(final InstructionHandle inst) {`
`399`	`399`	`final InstructionContext ic = instructionContexts.get(inst);`
`400`	`400`	`if (ic == null) {`
`401`		`- throw new AssertionViolatedException("InstructionContext requested for an InstructionHandle that's not known!");`
	`401`	`+ throw new AssertionViolatedException("InstructionContext requested for an InstructionHandle that's not known.");`
`402`	`402`	`}`
`403`	`403`	`return ic;`
`404`	`404`	`}`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ public void visitCHECKCAST(final CHECKCAST o) {`
`459`	`459`	`public void visitCPInstruction(final CPInstruction o) {`
`460`	`460`	`final int idx = o.getIndex();`
`461`	`461`	`if (idx < 0 \|\| idx >= cpg.getSize()) {`
`462`		`- throw new AssertionViolatedException("Huh?! Constant pool index of instruction '" + o + "' illegal? Pass 3a should have checked this!");`
	`462`	`+ throw new AssertionViolatedException("Huh?! Constant pool index of instruction '" + o + "' illegal? Pass 3a should have checked this.");`
`463`	`463`	`}`
`464`	`464`	`}`
`465`	`465`
`@@ -2360,7 +2360,7 @@ public void visitNEW(final NEW o) {`
`2360`	`2360`
`2361`	`2361`	`final Type t = o.getType(cpg);`
`2362`	`2362`	`if (!(t instanceof ReferenceType)) {`
`2363`		`- throw new AssertionViolatedException("NEW.getType() returning a non-reference type?!");`
	`2363`	`+ throw new AssertionViolatedException("NEW.getType() returning a non-reference type?.");`
`2364`	`2364`	`}`
`2365`	`2365`	`if (!(t instanceof ObjectType)) {`
`2366`	`2366`	`constraintViolated(o, "Expecting a class type (ObjectType) to work on. Found: '" + t + "'.");`
`@@ -2484,7 +2484,7 @@ public void visitRET(final RET o) {`
`2484`	`2484`	`constraintViolated(o, "Expecting a ReturnaddressType in local variable " + o.getIndex() + ".");`
`2485`	`2485`	`}`
`2486`	`2486`	`if (locals().get(o.getIndex()) == ReturnaddressType.NO_TARGET) {`
`2487`		`- throw new AssertionViolatedException("RET expecting a target!");`
	`2487`	`+ throw new AssertionViolatedException("RET expecting a target.");`
`2488`	`2488`	`}`
`2489`	`2489`	`// Other constraints such as non-allowed overlapping subroutines are enforced`
`2490`	`2490`	`// while building the Subroutines data structure.`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ private void circulationPump(final MethodGen m, final ControlFlowGraph cfg, fina`
`206`	`206`	`int skipJsr = 0;`
`207`	`207`	`for (int ss = oldchain.size() - 1; ss >= 0; ss--) {`
`208`	`208`	`if (skipJsr < 0) {`
`209`		`- throw new AssertionViolatedException("More RET than JSR in execution chain?!");`
	`209`	`+ throw new AssertionViolatedException("More RET than JSR in execution chain?.");`
`210`	`210`	`}`
`211`	`211`	`//System.err.println("+"+oldchain.get(ss));`
`212`	`212`	`if (oldchain.get(ss).getInstruction().getInstruction() instanceof JsrInstruction) {`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public void addEnteringJsrInstruction(final InstructionHandle jsrInst) {`
`110`	`110`	`throw new AssertionViolatedException("Expecting JsrInstruction InstructionHandle.");`
`111`	`111`	`}`
`112`	`112`	`if (localVariable == UNSET) {`
`113`		`- throw new AssertionViolatedException("Set the localVariable first!");`
	`113`	`+ throw new AssertionViolatedException("Set the localVariable first.");`
`114`	`114`	`}`
`115`	`115`	`// Something is wrong when an ASTORE is targeted that does not operate on the same local variable than the rest of the`
`116`	`116`	`// JsrInstruction-targets and the RET.`