Add JavaClassCyclicTest

Author: garydgregory

src/main/java/org/apache/bcel/classfile/JavaClass.java

@@ -467,9 +467,13 @@ private Field findFieldVisit(final String fieldName, final Type fieldType, final
     public JavaClass[] getAllInterfaces() throws ClassNotFoundException {
         final ClassQueue queue = new ClassQueue();
         final Set<JavaClass> allInterfaces = new TreeSet<>();
+        final Set<JavaClass> visited = new HashSet<>();
         queue.enqueue(this);
         while (!queue.empty()) {
             final JavaClass clazz = queue.dequeue();
+            if (!visited.add(clazz)) {
+                continue;
+            }
             final JavaClass souper = clazz.getSuperClass();
             final JavaClass[] interfaces = clazz.getInterfaces();
             if (clazz.isInterface()) {
@@ -693,7 +697,12 @@ public JavaClass getSuperClass() throws ClassNotFoundException {
     public JavaClass[] getSuperClasses() throws ClassNotFoundException {
         JavaClass clazz = this;
         final List<JavaClass> allSuperClasses = new ArrayList<>();
+        final Set<JavaClass> visited = new HashSet<>();
+        visited.add(this);
         for (clazz = clazz.getSuperClass(); clazz != null; clazz = clazz.getSuperClass()) {
+            if (!visited.add(clazz)) {
+                throw new ClassCircularityError(clazz.getClassName());
+            }
             allSuperClasses.add(clazz);
         }
         return allSuperClasses.toArray(EMPTY_ARRAY);