Normalize test class names to *Test

The pattern *TestCase is from the JUnit 3 era

Author: garydgregory

pom.xml

@@ -182,12 +182,14 @@
 			<PerformanceTest.report>false</PerformanceTest.report>
 		  </systemPropertyVariables>
           <includes>
+            <include>**/*Test.java</include>
             <include>**/*TestCase.java</include>
             <include>**/PerformanceTest.java</include>
           </includes>
           <excludes>
             <exclude>**/Abstract*</exclude>
             <!-- Takes rather a long time (especially rt.jar) ; only needs to be done occasionally -->
+            <exclude>**/JDKClassDumpTest.java</exclude>
             <exclude>**/JDKClassDumpTestCase.java</exclude>
           </excludes>
         </configuration>

…bcel/AbstractCounterVisitorTestCase.java …che/bcel/AbstractCounterVisitorTest.javasrc/test/java/org/apache/bcel/AbstractCounterVisitorTestCase.java renamed to src/test/java/org/apache/bcel/AbstractCounterVisitorTest.java src/test/java/org/apache/bcel/AbstractCounterVisitorTestCase.java renamed to src/test/java/org/apache/bcel/AbstractCounterVisitorTest.java

@@ -24,7 +24,7 @@
 import org.apache.bcel.visitors.CountingVisitor;
 import org.junit.jupiter.api.BeforeEach;
 
-public abstract class AbstractCounterVisitorTestCase extends AbstractTestCase {
+public abstract class AbstractCounterVisitorTest extends AbstractTest {
     private CountingVisitor visitor;
 
     protected abstract JavaClass getTestClass() throws ClassNotFoundException;

…va/org/apache/bcel/AbstractTestCase.java …t/java/org/apache/bcel/AbstractTest.javasrc/test/java/org/apache/bcel/AbstractTestCase.java renamed to src/test/java/org/apache/bcel/AbstractTest.java src/test/java/org/apache/bcel/AbstractTestCase.java renamed to src/test/java/org/apache/bcel/AbstractTest.java

@@ -43,11 +43,11 @@
 import org.apache.bcel.verifier.VerifierFactory;
 import org.apache.commons.io.function.Uncheck;
 
-public abstract class AbstractTestCase {
+public abstract class AbstractTest {
 
     private static final boolean VERBOSE = false;
 
-    protected static final String PACKAGE_BASE_NAME = AbstractTestCase.class.getPackage().getName();
+    protected static final String PACKAGE_BASE_NAME = AbstractTest.class.getPackage().getName();
 
     // Location of test data
     protected static final File TESTDATA = new File("target", "testdata");

…e/bcel/AnnotationAccessFlagTestCase.java …pache/bcel/AnnotationAccessFlagTest.javasrc/test/java/org/apache/bcel/AnnotationAccessFlagTestCase.java renamed to src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java src/test/java/org/apache/bcel/AnnotationAccessFlagTestCase.java renamed to src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java

@@ -25,7 +25,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class AnnotationAccessFlagTestCase extends AbstractTestCase {
+public class AnnotationAccessFlagTest extends AbstractTest {
     /**
      * If you write an annotation and compile it, the class file generated should be marked as an annotation type - which is
      * detectable through BCEL.

…/AnnotationDefaultAttributeTestCase.java …bcel/AnnotationDefaultAttributeTest.javasrc/test/java/org/apache/bcel/AnnotationDefaultAttributeTestCase.java renamed to src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java src/test/java/org/apache/bcel/AnnotationDefaultAttributeTestCase.java renamed to src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java

@@ -28,7 +28,7 @@
 import org.apache.bcel.classfile.SimpleElementValue;
 import org.junit.jupiter.api.Test;
 
-public class AnnotationDefaultAttributeTestCase extends AbstractTestCase {
+public class AnnotationDefaultAttributeTest extends AbstractTest {
     /**
      * For values in an annotation that have default values, we should be able to query the AnnotationDefault attribute
      * against the method to discover the default value that was originally declared.

…/apache/bcel/AnonymousClassTestCase.java …/org/apache/bcel/AnonymousClassTest.javasrc/test/java/org/apache/bcel/AnonymousClassTestCase.java renamed to src/test/java/org/apache/bcel/AnonymousClassTest.java src/test/java/org/apache/bcel/AnonymousClassTestCase.java renamed to src/test/java/org/apache/bcel/AnonymousClassTest.java

@@ -30,7 +30,7 @@
 import org.apache.bcel.data.EmptyClass;
 import org.junit.jupiter.api.Test;
 
-public class AnonymousClassTestCase extends AbstractTestCase {
+public class AnonymousClassTest extends AbstractTest {
     @Test
     public void testAnonymousInnerClassIsAnonymous() throws ClassNotFoundException {
         final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest$1");

…/apache/bcel/CounterVisitorTestCase.java …/org/apache/bcel/CounterVisitorTest.javasrc/test/java/org/apache/bcel/CounterVisitorTestCase.java renamed to src/test/java/org/apache/bcel/CounterVisitorTest.java src/test/java/org/apache/bcel/CounterVisitorTestCase.java renamed to src/test/java/org/apache/bcel/CounterVisitorTest.java

@@ -24,7 +24,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class CounterVisitorTestCase extends AbstractCounterVisitorTestCase {
+public class CounterVisitorTest extends AbstractCounterVisitorTest {
     @Override
     protected JavaClass getTestClass() throws ClassNotFoundException {
         return getTestJavaClass(PACKAGE_BASE_NAME + ".data.MarkedType");

…apache/bcel/ElementValueGenTestCase.java …org/apache/bcel/ElementValueGenTest.javasrc/test/java/org/apache/bcel/ElementValueGenTestCase.java renamed to src/test/java/org/apache/bcel/ElementValueGenTest.java src/test/java/org/apache/bcel/ElementValueGenTestCase.java renamed to src/test/java/org/apache/bcel/ElementValueGenTest.java

@@ -37,7 +37,7 @@
 import org.apache.bcel.generic.SimpleElementValueGen;
 import org.junit.jupiter.api.Test;
 
-public class ElementValueGenTestCase extends AbstractTestCase {
+public class ElementValueGenTest extends AbstractTest {
     private void checkSerialize(final ElementValueGen evgBefore, final ConstantPoolGen cpg) throws IOException {
         final String beforeValue = evgBefore.stringifyValue();
         final ByteArrayOutputStream baos = new ByteArrayOutputStream();

…el/EnclosingMethodAttributeTestCase.java …e/bcel/EnclosingMethodAttributeTest.javasrc/test/java/org/apache/bcel/EnclosingMethodAttributeTestCase.java renamed to src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java src/test/java/org/apache/bcel/EnclosingMethodAttributeTestCase.java renamed to src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java

@@ -32,7 +32,7 @@
 import org.apache.bcel.util.SyntheticRepository;
 import org.junit.jupiter.api.Test;
 
-public class EnclosingMethodAttributeTestCase extends AbstractTestCase {
+public class EnclosingMethodAttributeTest extends AbstractTest {
 
     /**
      * Check that we can save and load the attribute correctly.

…/apache/bcel/EnumAccessFlagTestCase.java …/org/apache/bcel/EnumAccessFlagTest.javasrc/test/java/org/apache/bcel/EnumAccessFlagTestCase.java renamed to src/test/java/org/apache/bcel/EnumAccessFlagTest.java src/test/java/org/apache/bcel/EnumAccessFlagTestCase.java renamed to src/test/java/org/apache/bcel/EnumAccessFlagTest.java

@@ -25,7 +25,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class EnumAccessFlagTestCase extends AbstractTestCase {
+public class EnumAccessFlagTest extends AbstractTest {
     /**
      * An enumerated type, once compiled, should result in a class file that is marked such that we can determine from the
      * access flags (through BCEL) that it was originally an enum type declaration.