Use JUnit 5 convention for class visibility

Author: garydgregory

src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java

@@ -25,7 +25,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class AnnotationAccessFlagTest extends AbstractTest {
+class AnnotationAccessFlagTest extends AbstractTest {
     /**
      * If you write an annotation and compile it, the class file generated should be marked as an annotation type - which is
      * detectable through BCEL.

src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java

@@ -28,7 +28,7 @@
 import org.apache.bcel.classfile.SimpleElementValue;
 import org.junit.jupiter.api.Test;
 
-public class AnnotationDefaultAttributeTest extends AbstractTest {
+class AnnotationDefaultAttributeTest extends AbstractTest {
     /**
      * For values in an annotation that have default values, we should be able to query the AnnotationDefault attribute
      * against the method to discover the default value that was originally declared.

src/test/java/org/apache/bcel/AnnotationEntryTest.java

@@ -34,7 +34,7 @@
 /**
  * Tests {@link AnnotationEntry}.
  */
-public class AnnotationEntryTest {
+class AnnotationEntryTest {
 
     @Test
     void testAddElementNameValuePair() {

src/test/java/org/apache/bcel/AnonymousClassTest.java

@@ -30,7 +30,7 @@
 import org.apache.bcel.data.EmptyClass;
 import org.junit.jupiter.api.Test;
 
-public class AnonymousClassTest extends AbstractTest {
+class AnonymousClassTest extends AbstractTest {
     @Test
     void testAnonymousInnerClassIsAnonymous() throws ClassNotFoundException {
         final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest$1");

src/test/java/org/apache/bcel/ConstTest.java

@@ -26,7 +26,7 @@
 /**
  * Tests {@link Const}.
  */
-public class ConstTest {
+class ConstTest {
 
     @Test
     void testJava22() throws Exception {

src/test/java/org/apache/bcel/CounterVisitorTest.java

@@ -24,7 +24,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class CounterVisitorTest extends AbstractCounterVisitorTest {
+class CounterVisitorTest extends AbstractCounterVisitorTest {
     @Override
     protected JavaClass getTestClass() throws ClassNotFoundException {
         return getTestJavaClass(PACKAGE_BASE_NAME + ".data.MarkedType");

src/test/java/org/apache/bcel/ElementValueGenTest.java

@@ -37,7 +37,7 @@
 import org.apache.bcel.generic.SimpleElementValueGen;
 import org.junit.jupiter.api.Test;
 
-public class ElementValueGenTest extends AbstractTest {
+class ElementValueGenTest extends AbstractTest {
     private void checkSerialize(final ElementValueGen evgBefore, final ConstantPoolGen cpg) throws IOException {
         final String beforeValue = evgBefore.stringifyValue();
         final ByteArrayOutputStream baos = new ByteArrayOutputStream();

src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java

@@ -32,7 +32,7 @@
 import org.apache.bcel.util.SyntheticRepository;
 import org.junit.jupiter.api.Test;
 
-public class EnclosingMethodAttributeTest extends AbstractTest {
+class EnclosingMethodAttributeTest extends AbstractTest {
 
     /**
      * Check that we can save and load the attribute correctly.

src/test/java/org/apache/bcel/EnumAccessFlagTest.java

@@ -25,7 +25,7 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.junit.jupiter.api.Test;
 
-public class EnumAccessFlagTest extends AbstractTest {
+class EnumAccessFlagTest extends AbstractTest {
     /**
      * An enumerated type, once compiled, should result in a class file that is marked such that we can determine from the
      * access flags (through BCEL) that it was originally an enum type declaration.

src/test/java/org/apache/bcel/HandleTest.java

@@ -30,7 +30,7 @@
  * Test for https://issues.apache.org/jira/browse/BCEL-267 "Race conditions on static fields in BranchHandle and
  * InstructionHandle".
  */
-public class HandleTest {
+class HandleTest {
 
     static Throwable exception;
     static final int MAXI = 100;