Fix ConstantPoolModuleAccessTest failures on Java 25#469
Merged
Conversation
garydgregory
reviewed
Oct 1, 2025
garydgregory
left a comment
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @iloveeclipse
Thank you for your PR. Please see my comment.
Contributor
Author
|
@garydgregory : could you please "approve" workflows to let the tests run? |
Member
Updated test expectations according to changes in module-info classes shipped with JDK 25.
iloveeclipse
force-pushed
the
jdk_25_test_fixes
branch
from
2a1f249 to
b04fbc5
Compare
Contributor
Author
|
I've fixed tab character only. The
|
Member
|
Merged, thank you @iloveeclipse ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated test expectations according to changes in module-info classes shipped with JDK 25.