Skip to content

Handle SQLException on connection initialization with SQL statements#540

Merged
garydgregory merged 2 commits into
apache:masterfrom
garydgregory:bugfix/sql_exception_on_init_connection
Dec 17, 2025
Merged

Handle SQLException on connection initialization with SQL statements#540
garydgregory merged 2 commits into
apache:masterfrom
garydgregory:bugfix/sql_exception_on_init_connection

Conversation

@garydgregory

@garydgregory garydgregory commented Dec 15, 2025

Copy link
Copy Markdown
Member

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory
Revert "Fix potential resource leak on exception in initializeConnect…
febb409 
…ion()"

This reverts commit 914130f.
@garydgregory
Handle SQLException from
ec8dd1f 
PoolableConnectionFactory.initializeConnection()

- Revert previous commit
- The call site that creates the connection closes it, just like
PoolableConnectionFactory.makeObject()
@markt-asf

markt-asf commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

LGTM

@garydgregory garydgregory merged commit f8984f3 into apache:master Dec 17, 2025
9 checks passed
@garydgregory garydgregory deleted the bugfix/sql_exception_on_init_connection branch December 17, 2025 00:04
garydgregory added a commit that referenced this pull request Dec 17, 2025
@garydgregory
Document Handle SQLException on connection initialization with SQL
67b82dd 
statements (#540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markt-asf markt-asf Awaiting requested review from markt-asf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garydgregory @markt-asf