org.apache.commons.mail2.jakarta.util.MimeMessageUtils.createMimeMessage(Session,

File) now uses NIO

org.apache.commons.mail2.javax.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO

Author: garydgregory

commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java

@@ -17,7 +17,6 @@
 package org.apache.commons.mail2.jakarta.util;
 
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
@@ -64,9 +63,7 @@ public static MimeMessage createMimeMessage(final Session session, final byte[]
      * @throws IOException        creating the MimeMessage failed.
      */
     public static MimeMessage createMimeMessage(final Session session, final File source) throws MessagingException, IOException {
-        try (InputStream inputStream = new FileInputStream(source)) {
-            return createMimeMessage(session, inputStream);
-        }
+        return createMimeMessage(session, source.toPath());
     }
 
     /**

commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java

@@ -17,7 +17,6 @@
 package org.apache.commons.mail2.javax.util;
 
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
@@ -64,9 +63,7 @@ public static MimeMessage createMimeMessage(final Session session, final byte[]
      * @throws IOException        creating the MimeMessage failed.
      */
     public static MimeMessage createMimeMessage(final Session session, final File source) throws MessagingException, IOException {
-        try (InputStream inputStream = new FileInputStream(source)) {
-            return createMimeMessage(session, inputStream);
-        }
+        return createMimeMessage(session, source.toPath());
     }
 
     /**

src/changes/changes.xml

@@ -37,6 +37,8 @@
       <action type="update" due-to="Gary Gregory" dev="ggregory">EmailException doesn't need to override printStackTrace().</action>
       <action type="update" due-to="Gary Gregory" dev="ggregory">EmailException doesn't need to override printStackTrace(PrintStream).</action>
       <action type="update" due-to="Gary Gregory" dev="ggregory">EmailException doesn't need to override printStackTrace(PrintWriter).</action>
+      <action type="update" due-to="Gary Gregory" dev="ggregory">org.apache.commons.mail2.jakarta.util.MimeMessageUtils.createMimeMessage(Session, File) now uses NIO.</action>
+      <action type="update" due-to="Gary Gregory" dev="ggregory">org.apache.commons.mail2.javax.util.MimeMessageUtils.createMimeMessage(Session, File) now uses NIO.</action>
     </release>
     <release version="2.0.0-M1" date="2024-06-15" description="Feature release (Java 8 or above).">
       <!-- ADD -->