[IO-279] Fix macos-x-13-java8 unstable test due to posix file time#760
Merged
garydgregory merged 1 commit intoJul 6, 2025
Merged
Conversation
… resolution is only 1s. Adding TestUtils.sleepTillNextFullSecond()
garydgregory
changed the title
Member
|
Thank you for the follow-up PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… resolution is only 1s. Adding TestUtils.sleepTillNextFullSecond()
@garydgregory
followup to PR #757 . The test was unstable, as the java.nio.file.Files.getLastModifiedTime() on macosx-13-java8 only has a time resolution of 1s (and it is used in Tailer.TailablePath.lastModifiedFIleTIme).
Note: it seems, that java.io.File.lastModified() has millisecond resolution on that platform, but it doesn't make sense to change the real code for everyone because of an odd platform.
So tests are now adapated, that the file date is updated after the curent second has passed to comply with posix standard Additionaly the waittime is shortened a little by polling instead of waiting max time.
see https://github.com/JoergBudi/commons-io/actions/runs/16092357707/job/45410764092 for passed test.