Add test coverage for negative-day adjustment in

DurationFormatUtils #1596

- Sort new methods
- Remove empty lines, use longer lines

Author: garydgregory

src/changes/changes.xml

@@ -116,6 +116,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action                   type="fix" dev="ggregory" due-to="Ivan Ponomarev, Gary Gregory">ThreadUtils.sleepQuietly(Duration) now restores the current thread's interrupt flag when catching InterruptedException.</action>
     <action issue="LANG-1817" type="fix" dev="ggregory" due-to="Ivan Ponomarev, Gary Gregory">UncheckedFutureImpl clears thread interrupt status when wrapping InterruptedException #1590.</action>
     <action                   type="fix" dev="ggregory" due-to="ThrawnCA, Gary Gregory">Fix StringUtils.abbreviate(String, String, int) contract violations #1572.</action>
+    <action                   type="fix" dev="ggregory" due-to="TK_ENDO, Arnout Engelen, Gary Gregory">Add test coverage for negative-day adjustment in DurationFormatUtils #1596.</action>
     <!-- ADD -->
     <action                   type="add" dev="ggregory" due-to="Gary Gregory">Add JavaVersion.JAVA_27.</action>
     <action                   type="add" dev="ggregory" due-to="Gary Gregory">Add SystemUtils.IS_JAVA_27.</action>

src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java

@@ -473,54 +473,6 @@ void testFormatPeriod() {
         assertEquals("helloworld", DurationFormatUtils.formatPeriod(time1970, time, "'hello''world'"));
     }
 
-    @Test
-    void testFormatPeriodISOAcrossMonths() {
-        final TimeZone tz = TimeZones.getTimeZone("GMT-3");
-
-        // Verifies period formatting across a month boundary (Jan 31 to Feb 1)
-        final Calendar start = Calendar.getInstance(tz);
-        start.clear();
-        start.set(2020, Calendar.JANUARY, 31);
-
-        final Calendar end = Calendar.getInstance(tz);
-        end.clear();
-        end.set(2020, Calendar.FEBRUARY, 1);
-
-        final String result = DurationFormatUtils.formatPeriod(
-                start.getTimeInMillis(),
-                end.getTimeInMillis(),
-                DurationFormatUtils.ISO_EXTENDED_FORMAT_PATTERN,
-                false,
-                tz
-        );
-
-        assertEquals("P0Y0M1DT0H0M0.000S", result);
-    }
-
-    @Test
-    void testFormatPeriodISOLeapYearBoundary() {
-        final TimeZone tz = TimeZones.getTimeZone("GMT-3");
-
-        // Verifies period formatting across a leap-year boundary (Feb 29 to Mar 1)
-        final Calendar start = Calendar.getInstance(tz);
-        start.clear();
-        start.set(2020, Calendar.FEBRUARY, 29);
-
-        final Calendar end = Calendar.getInstance(tz);
-        end.clear();
-        end.set(2020, Calendar.MARCH, 1);
-
-        final String result = DurationFormatUtils.formatPeriod(
-                start.getTimeInMillis(),
-                end.getTimeInMillis(),
-                DurationFormatUtils.ISO_EXTENDED_FORMAT_PATTERN,
-                false,
-                tz
-        );
-
-        assertEquals("P0Y0M1DT0H0M0.000S", result);
-    }
-
     @Test
     void testFormatPeriodeStartGreaterEnd() {
         assertIllegalArgumentException(() -> DurationFormatUtils.formatPeriod(5000, 2500, "yy/MM"));
@@ -555,6 +507,36 @@ void testFormatPeriodISO() {
         // assertEquals("P1Y2M3DT10H30M", text);
     }
 
+    @Test
+    void testFormatPeriodISOAcrossMonths() {
+        final TimeZone tz = TimeZones.getTimeZone("GMT-3");
+        // Verifies period formatting across a month boundary (Jan 31 to Feb 1)
+        final Calendar start = Calendar.getInstance(tz);
+        start.clear();
+        start.set(2020, Calendar.JANUARY, 31);
+        final Calendar end = Calendar.getInstance(tz);
+        end.clear();
+        end.set(2020, Calendar.FEBRUARY, 1);
+        final String result = DurationFormatUtils.formatPeriod(start.getTimeInMillis(), end.getTimeInMillis(), DurationFormatUtils.ISO_EXTENDED_FORMAT_PATTERN,
+                false, tz);
+        assertEquals("P0Y0M1DT0H0M0.000S", result);
+    }
+
+    @Test
+    void testFormatPeriodISOLeapYearBoundary() {
+        final TimeZone tz = TimeZones.getTimeZone("GMT-3");
+        // Verifies period formatting across a leap-year boundary (Feb 29 to Mar 1)
+        final Calendar start = Calendar.getInstance(tz);
+        start.clear();
+        start.set(2020, Calendar.FEBRUARY, 29);
+        final Calendar end = Calendar.getInstance(tz);
+        end.clear();
+        end.set(2020, Calendar.MARCH, 1);
+        final String result = DurationFormatUtils.formatPeriod(start.getTimeInMillis(), end.getTimeInMillis(), DurationFormatUtils.ISO_EXTENDED_FORMAT_PATTERN,
+                false, tz);
+        assertEquals("P0Y0M1DT0H0M0.000S", result);
+    }
+
     @Test
     void testFormatPeriodISOMethod() {
         assertEquals("P0Y0M0DT0H0M0.000S", DurationFormatUtils.formatPeriodISO(0L, 0L));