Deprecate NumberUtils.compare(short, short) in favor of

Short.compare(short, short)

Author: garydgregory

src/changes/changes.xml

@@ -64,6 +64,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(byte, byte) in favor of Byte.compare(byte, byte).</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(int, int) in favor of Integer.compare(int, int).</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(long, long) in favor of Long.compare(long, long).</action>
+    <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(short, short) in favor of Short.compare(short, short).</action>
     <!-- FIX Javadoc -->
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] General improvements.</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] Fix thrown exception documentation for org.apache.commons.lang3.reflect.MethodUtils.getMethodObject(Class&lt;?&gt;, String, Class&lt;?&gt;...).</action>

src/main/java/org/apache/commons/lang3/ArrayUtils.java

@@ -39,7 +39,6 @@
 import org.apache.commons.lang3.builder.ToStringBuilder;
 import org.apache.commons.lang3.builder.ToStringStyle;
 import org.apache.commons.lang3.function.FailableFunction;
-import org.apache.commons.lang3.math.NumberUtils;
 import org.apache.commons.lang3.mutable.MutableInt;
 import org.apache.commons.lang3.stream.IntStreams;
 import org.apache.commons.lang3.stream.Streams;
@@ -3760,7 +3759,7 @@ public static boolean isSorted(final short[] array) {
         final int n = array.length;
         for (int i = 1; i < n; i++) {
             final short current = array[i];
-            if (NumberUtils.compare(previous, current) > 0) {
+            if (Short.compare(previous, current) > 0) {
                 return false;
             }
             previous = current;

src/main/java/org/apache/commons/lang3/math/NumberUtils.java

@@ -143,12 +143,11 @@ public static int compare(final long x, final long y) {
      *         a value less than {@code 0} if {@code x < y}; and
      *         a value greater than {@code 0} if {@code x > y}
      * @since 3.4
+     * @deprecated Use {@link Short#compare(short, short)}.
      */
+    @Deprecated
     public static int compare(final short x, final short y) {
-        if (x == y) {
-            return 0;
-        }
-        return x < y ? -1 : 1;
+        return Short.compare(x, y);
     }
 
     /**

src/main/java/org/apache/commons/lang3/mutable/MutableShort.java

@@ -16,8 +16,6 @@
  */
 package org.apache.commons.lang3.mutable;
 
-import org.apache.commons.lang3.math.NumberUtils;
-
 /**
  * A mutable {@code short} wrapper.
  * <p>
@@ -131,7 +129,7 @@ public short addAndGet(final short operand) {
      */
     @Override
     public int compareTo(final MutableShort other) {
-        return NumberUtils.compare(this.value, other.value);
+        return Short.compare(this.value, other.value);
     }
 
     /**