fix review comments

Author: inponomarev

src/main/java/org/apache/commons/lang3/ClassUtils.java

@@ -1027,7 +1027,6 @@ public static String getShortClassName(final Class<?> cls) {
             dim++;
             c = c.getComponentType();
         }
-
         final String base;
         // Preserve legacy behavior for anonymous/local classes (keeps compiler ordinals: $13, $10Named, etc.)
         if (c.isAnonymousClass() || c.isLocalClass()) {
@@ -1039,14 +1038,9 @@ public static String getShortClassName(final Class<?> cls) {
                 parts.push(x.getSimpleName());
                 x = x.getDeclaringClass();
             }
-            base = String.join(String.valueOf(PACKAGE_SEPARATOR_CHAR), parts);
-        }
-
-        final StringBuilder sb = new StringBuilder(base);
-        for (int i = 0; i < dim; i++) {
-            sb.append("[]");
+            base = String.join(".", parts);
         }
-        return sb.toString();
+        return base + StringUtils.repeat("[]", dim);
     }
 
     /**

src/test/java/org/apache/commons/lang3/ClassUtilsShortClassNameTest.java

@@ -30,7 +30,7 @@ class Pa$$word {
 }
 
 /**
- * Tests for https://issues.apache.org/jira/browse/LANG-1818
+ * Tests for <a href="https://issues.apache.org/jira/browse/LANG-1818">LANG-1818</a>
  */
 public class ClassUtilsShortClassNameTest {
 
@@ -46,31 +46,29 @@ class Ne$ted {
 
     @Test
     void testDollarSignImmediatelyAfterPackage() {
-        String result = ClassUtils.getShortClassName($trange.class);
-        assertEquals("$trange", result);
+        assertEquals("$trange", ClassUtils.getShortClassName($trange.class));
     }
 
     @Test
     void testDollarSignWithinName() {
-        String result = ClassUtils.getShortClassName(Pa$$word.class);
-        assertEquals("Pa$$word", result);
+        assertEquals("Pa$$word", ClassUtils.getShortClassName(Pa$$word.class));
     }
 
     @Test
     void testMultipleDollarSigns() {
-        String result = ClassUtils.getShortClassName($Inner.class);
-        assertEquals(getClass().getSimpleName() + ".$Inner", result);
+        assertEquals(getClass().getSimpleName() + ".$Inner",
+                ClassUtils.getShortClassName($Inner.class));
     }
 
     @Test
     void testInnerClassName() {
-        String result = ClassUtils.getShortClassName(Inner.class);
-        assertEquals(getClass().getSimpleName() + ".Inner", result);
+        assertEquals(getClass().getSimpleName() + ".Inner",
+                ClassUtils.getShortClassName(Inner.class));
     }
 
     @Test
     void testNe$tedClassName() {
-        String result = ClassUtils.getShortClassName(Inner.Ne$ted.class);
-        assertEquals(getClass().getSimpleName() + ".Inner.Ne$ted", result);
+        assertEquals(getClass().getSimpleName() + ".Inner.Ne$ted",
+                ClassUtils.getShortClassName(Inner.Ne$ted.class));
     }
 }