Clarify truncate method Javadoc#1536
Conversation
Improves the truncate method documentation to better describe substring behavior.
garydgregory
left a comment
There was a problem hiding this comment.
Hello @Akshat19Upadhyay
Thank you for the PR.
Please rebase on git master and see my comment.
Clarifies return value description and removes extra line break.
Updates the truncate Javadoc to clarify behavior when the String is shorter than maxWidth and that zero is a valid non-negative value.
|
Thanks for the review. |
garydgregory
left a comment
There was a problem hiding this comment.
The new text is still wrong.
|
Hi @garydgregory, thanks for the review. |
|
Hello @Akshat19Upadhyay I picked up the change that I think matters in git master ( Thank you! |
Improves the truncate method documentation to better describe substring behavior.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.