Skip to content

[LANG-1448] Fix invalid Java examples in StringUtils.containsOnly Javadoc#1542

Closed
kamGP92 wants to merge 2 commits intoapache:masterfrom
kamGP92:lang-1448-javadoc-fix
Closed

[LANG-1448] Fix invalid Java examples in StringUtils.containsOnly Javadoc#1542
kamGP92 wants to merge 2 commits intoapache:masterfrom
kamGP92:lang-1448-javadoc-fix

Conversation

@kamGP92
Copy link
Copy Markdown

@kamGP92 kamGP92 commented Dec 23, 2025

This PR fixes the invalid Java examples in Javadoc of StringUtils.containsOnly.
The old examples were non-compilable (like 'abab', 'abc').

Updated the

 block to use correct char arguments for the varargs signature:
StringUtils.containsOnly( "abab", 'a', 'b', 'c') = true

No functional changes; this only updates documentation.

Copy link
Copy Markdown
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1: This PR contains a change to a method that doesn't match its signature and should not be changed.

@kamGP92
Copy link
Copy Markdown
Author

kamGP92 commented Dec 24, 2025

-1: This PR contains a change to a method that doesn't match its signature and should not be changed.

Thanks for pointing that out.
I've updated the examples to follow the same pseudo-code notation used by containsAny , keeping the documentation style consistent across the class.

@garydgregory
Copy link
Copy Markdown
Member

garydgregory commented Dec 24, 2025

Hello @kamGP92

Please rebase on git master. I believe this PR is no longer necessary.

Tracking Jira: LANG-1448

@kamGP92
Copy link
Copy Markdown
Author

kamGP92 commented Dec 24, 2025

Hello @kamGP92

Please rebase on git master. I believe this PR is no longer necessary.

Tracking Jira: LANG-1448

Rebased on current master
The issue appears to be resolved upstream, so this PR can be closed.
Thanks for the review.

@kamGP92 kamGP92 closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants