[LANG-1806] NumberUtils.isParsable("1.f") should return true#1560
Merged
garydgregory merged 17 commits intoapache:masterfrom Jan 11, 2026
Merged
Conversation
- Return true for numbers like 1.2e-5d and 1.2e-5f - Use a regular expression
garydgregory
changed the title
- Return true for numbers like 1.2e-5d and 1.2e-5f - Return true when one of the following would work: -- Double.parseDouble(String) -- Float.parseFloat(String) -- Long.parseLong(String) -- Integer.parseInteger(String) There are so many cases that it's simpler to try to parse and catch exceptions, instead of re-creating all the parsing rules from the JRE. The only downside is that number instances are created and discarded.
garydgregory
force-pushed
the
bugfix/LANG-1806_NumberUtils_isParsable
branch
from
670badc to
06a6b1f
Compare
garydgregory
added a commit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[LANG-1806] NumberUtils.isParsable("1.f") should return true
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.