[LANG-1452] RecursiveToStringStyle and MultilineRecursiveToStringStyle shouldn't recurse into a java.math.BigDecimal#1582
Closed
chhs2131 wants to merge 1 commit intoapache:masterfrom
Closed
[LANG-1452] RecursiveToStringStyle and MultilineRecursiveToStringStyle shouldn't recurse into a java.math.BigDecimal#1582chhs2131 wants to merge 1 commit intoapache:masterfrom
chhs2131 wants to merge 1 commit intoapache:masterfrom
Conversation
…ng in MultilineRecursiveToStringStyle Prevent exposing internal fields (intVal, scale, mag, signum) when formatting BigDecimal and BigInteger objects. Override accept() method to exclude these immutable value types from recursive formatting. - Add BigInteger to exclusion list alongside BigDecimal - Update Javadoc to document the exclusion - Add testBigIntegerField() test case
chhs2131
changed the title
Member
Author
|
@garydgregory |
Member
|
YW! 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Addresses LANG-1452 by excluding
BigDecimalandBigIntegerfrom recursive formatting inMultilineRecursiveToStringStyleto prevent exposing internal implementation fields.Changes
accept(Class<?>)method to returnfalseforBigDecimalandBigIntegertestBigDecimalField()test casetestBigIntegerField()test caseWhy
MultilineRecursiveToStringStylewas recursively formattingBigDecimalandBigIntegerobjects, exposing internal fields likeintVal,scale,mag, andsignuminstead of their string values. This follows the intended design pattern ofRecursiveToStringStyle, where subclasses can overrideaccept()to filter specific classes from recursive processing.