double leading dot on first line in DotTerminatedMessageWriter#398
Open
dxbjavid wants to merge 1 commit into
Open
double leading dot on first line in DotTerminatedMessageWriter#398dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotTerminatedMessageWriter starts in NOTHING_SPECIAL_STATE, so a period at the very start of the message isn't doubled even though it's the start of a line. A body beginning with "." then CRLF therefore ends the data phase early (SMTP DATA, NNTP POST, POP3), letting the following text be read as protocol commands. Initialize the state to LAST_WAS_NL_STATE so the message start is treated as a line start, matching the reader's un-stuffing.