reject CR/LF in IMAP quoteMailboxName#399
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quoteMailboxName is what wraps mailbox names before they go into SELECT/CREATE/RENAME/COPY/etc., but it only quotes when the value has a space and never looks at line terminators. A name like
INBOX\r\nA001 DELETE "Sent"is passed through untouched, so the CRLF ends the line and the rest is sent as a second IMAP command on the control connection. Rejecting CR/LF here, the same way SimpleSMTPHeader/SimpleNNTPHeader already do, closes that off without changing the existing quoting behavior.