PMD: allow public members in non public type

Added exclusions to allow build using PMD 7.21.0.

See also: pmd/pmd#6477

Author: aherbert

commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalUtils.java

@@ -271,6 +271,10 @@ static double makeNonZeroDouble(long v) {
      * It allows to allocate a cache of precomputed values.
      * In case of cache miss, computation is performed by a call to
      * {@link InternalGamma#logGamma(double)}.
+     *
+     * <p>TODO: Remove public modifiers in next major release. This class is
+     * effectively package-private but changing triggers a false-positive
+     * binary compatibility failure using japicmp.
      */
     public static final class FactorialLog {
         /**

src/conf/pmd/pmd-ruleset.xml

@@ -240,6 +240,16 @@
         value="./ancestor-or-self::ClassDeclaration[@SimpleName='LargeMeanPoissonSamplerState']"/>
     </properties>
   </rule>
+  <rule ref="category/java/design.xml/PublicMemberInNonPublicType">
+    <properties>
+      <!-- AbstractWell.IndexTable is a protected class for use in derived classes of the
+        public outer class. InternalUtils.FactorialLog should be package-private but this
+        change is not allowed by japicmp (false positive). -->
+      <property name="violationSuppressXPath"
+        value="./ancestor-or-self::ClassDeclaration[@SimpleName='IndexTable'
+          or @SimpleName='FactorialLog']"/>
+    </properties>
+  </rule>
 
   <rule ref="category/java/documentation.xml/CommentRequired">
     <properties>