Skip to content

Commit f5c0bb5

Browse files
committed
Update revapi configuration
Use commons.bc.version for artifact to compare. Use distinct ids in each configuration section. Use ignore explicitly in the build configuration but not in reporting (to allow the change to be reported). Add missing 1.7 root to reporting section.
1 parent 73f1e98 commit f5c0bb5

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

pom.xml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,14 @@
287287
</dependency>
288288
</dependencies>
289289
<configuration>
290+
<oldArtifacts>
291+
<artifact>${project.groupId}:${project.artifactId}:${commons.bc.version}</artifact>
292+
</oldArtifacts>
290293
<analysisConfiguration>
291-
<revapi.differences id="intentional-api-changes">
294+
<revapi.differences id="intentional-api-changes-1_5">
295+
<ignore>true</ignore>
296+
</revapi.differences>
297+
<revapi.differences id="intentional-api-changes-1_7">
292298
<ignore>true</ignore>
293299
</revapi.differences>
294300
</analysisConfiguration>
@@ -637,13 +643,17 @@ This is avoided by creating an empty directory when svn is not available.
637643
<artifactId>revapi-maven-plugin</artifactId>
638644
<version>${rng.revapi.version}</version>
639645
<configuration>
646+
<oldArtifacts>
647+
<artifact>${project.groupId}:${project.artifactId}:${commons.bc.version}</artifact>
648+
</oldArtifacts>
640649
<!-- For reporting do not ignore the "intentional-api-changes" so they are included -->
641650
<analysisConfigurationFiles>
642651
<configurationFile>
643652
<path>${rng.parent.dir}/src/conf/revapi/api-changes.json</path>
644653
<roots>
645654
<!-- Path(s) to configuration in the JSON config file -->
646655
<root>1.5</root>
656+
<root>1.7</root>
647657
</roots>
648658
</configurationFile>
649659
</analysisConfigurationFiles>

src/conf/revapi/api-changes.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"1.5": [
33
{
44
"extension": "revapi.differences",
5-
"id": "intentional-api-changes",
5+
"id": "intentional-api-changes-1_5",
66
"configuration": {
77
"differences": [
88
{
@@ -11,7 +11,6 @@
1111
"justification": "Abstract method added to enum; all implementations are within this class. This is an internal package with no compatibility enforcement."
1212
},
1313
{
14-
"ignore": true,
1514
"code": "java.class.externalClassExposedInAPI",
1615
"new": "interface org.apache.commons.rng.SplittableUniformRandomProvider",
1716
"justification": "Split support was added to the client API and can be used by other modules."
@@ -23,11 +22,10 @@
2322
"1.7": [
2423
{
2524
"extension": "revapi.differences",
26-
"id": "intentional-api-changes",
25+
"id": "intentional-api-changes-1_7",
2726
"configuration": {
2827
"differences": [
2928
{
30-
"ignore": true,
3129
"code": "java.class.externalClassExposedInAPI",
3230
"new": "interface org.apache.commons.rng.ArbitrarilyJumpableUniformRandomProvider",
3331
"justification": "Arbitrary jump support was added to the client API and can be used by other modules."

0 commit comments

Comments
 (0)