Skip to content

Commit 4191840

Browse files
committed
replacing bit faster version of empty check
1 parent 325658b commit 4191840

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public Double apply(final CharSequence left, final CharSequence right) {
8585
return 1d;
8686
}
8787

88-
if ("".equals(left) || "".equals(right)) {
88+
if (left.length() == 0 || right.length() == 0) {
8989
return 0d;
9090
}
9191

src/test/java/org/apache/commons/text/similarity/SorensenDicesSimilarityTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ public void test() {
4343
public void testGetSorensenDicesSimilarity_StringString() {
4444

4545
assertEquals(1d, similarity.apply("", ""));
46+
assertEquals(0d, similarity.apply("", "a"));
47+
assertEquals(0d, similarity.apply("a", ""));
4648
assertEquals(1.0d, similarity.apply("foo", "foo"));
4749
assertEquals(0.8d, similarity.apply("foo", "foo "));
4850
assertEquals(0.4d, similarity.apply("frog", "fog"));

0 commit comments

Comments
 (0)