Skip to content

Commit 115b4f0

Browse files
committed
classify xn--90ae (бг) as a country-code TLD
1 parent d5cf1a3 commit 115b4f0

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/main/java/org/apache/commons/validator/routines/DomainValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,6 @@ private static class LazyHolder { // IODH
13701370
"xn--80asehdb", // онлайн CORE Association
13711371
"xn--80aswg", // сайт CORE Association
13721372
"xn--8y0a063a", // 联通 China United Network Communications Corporation Limited
1373-
"xn--90ae", // бг Imena.BG Plc (NAMES.BG Plc)
13741373
"xn--9dbq2a", // קום VeriSign Sarl
13751374
"xn--9et52u", // 时尚 RISE VICTORY LIMITED
13761375
"xn--9krt00a", // 微博 Sina Corporation
@@ -1725,6 +1724,7 @@ private static class LazyHolder { // IODH
17251724
"xn--54b7fta0cc", // বাংলা Posts and Telecommunications Division
17261725
"xn--80ao21a", // қаз Association of IT Companies of Kazakhstan
17271726
"xn--90a3ac", // срб Serbian National Internet Domain Registry (RNIDS)
1727+
"xn--90ae", // бг Imena.BG Plc (NAMES.BG Plc)
17281728
"xn--90ais", // ??? Reliable Software Inc.
17291729
"xn--clchc0ea0b2g2a9gcd", // சிங்கப்பூர் Singapore Network Information Centre (SGNIC) Pte Ltd
17301730
"xn--d1alf", // мкд Macedonian Academic Research Network Skopje

src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,10 @@ void testTopLevelDomains() {
584584
assertTrue(validator.isValidCountryCodeTld(".uk"), ".uk should validate as ccTLD");
585585
assertFalse(validator.isValidCountryCodeTld(".org"), ".org shouldn't validate as ccTLD");
586586

587+
// бг (xn--90ae) is the IDN ccTLD for Bulgaria, not a gTLD
588+
assertTrue(validator.isValidCountryCodeTld("xn--90ae"), "xn--90ae (бг) should validate as ccTLD");
589+
assertFalse(validator.isValidGenericTld("xn--90ae"), "xn--90ae (бг) shouldn't validate as gTLD");
590+
587591
// case-insensitive
588592
assertTrue(validator.isValidTld(".COM"), ".COM should validate as TLD");
589593
assertTrue(validator.isValidTld(".BiZ"), ".BiZ should validate as TLD");

0 commit comments

Comments
 (0)