Refactor to always calling FileContent.getOutputStream

... instead of `AbstractFileObject.getOutputStream`. This allows us to
not call `endOutput` explicitly from anywhere other than `DefaultFileContent`

Author: boris-petrov

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java

@@ -321,8 +321,9 @@ public void createFile() throws FileSystemException {
                 }
 
                 if (!exists()) {
-                    getOutputStream().close();
-                    endOutput();
+                    try (FileContent content = getContent()) {
+                        content.getOutputStream().close();
+                    }
                 }
             } catch (final RuntimeException re) {
                 throw re;

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileOutputStream.java

@@ -19,8 +19,6 @@
 import java.io.IOException;
 import java.io.OutputStream;
 
-import org.apache.commons.vfs2.FileSystemException;
-
 /**
  * OutputStream to a RamFile.
  */
@@ -92,13 +90,7 @@ public void close() throws IOException {
         if (exception != null) {
             throw exception;
         }
-        try {
-            this.closed = true;
-            // Close the
-            this.file.endOutput();
-        } catch (final Exception e) {
-            throw new FileSystemException(e);
-        }
+        this.closed = true;
     }
 
 }

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java

@@ -25,10 +25,10 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.Map;
 
 import org.apache.commons.vfs2.Capability;
+import org.apache.commons.vfs2.FileContent;
 import org.apache.commons.vfs2.FileName;
 import org.apache.commons.vfs2.FileObject;
 import org.apache.commons.vfs2.FileSystemException;
@@ -218,22 +218,14 @@ void toRamFileObject(final FileObject fo, final FileObject root) throws FileSyst
             }
         } else if (fo.isFile()) {
             // Read bytes
-            try {
-                final InputStream is = fo.getContent().getInputStream();
-                try {
-                    final OutputStream os = new BufferedOutputStream(memFo.getOutputStream(), BUFFER_SIZE);
-                    int i;
-                    while ((i = is.read()) != -1) {
-                        os.write(i);
-                    }
-                    os.close();
-                } finally {
-                    try {
-                        is.close();
-                    } catch (final IOException ignored) {
-                        /* ignore on close exception. */
-                    }
-                    // TODO: close os
+            try (
+            		InputStream is = fo.getContent().getInputStream();
+            		FileContent content = memFo.getContent();
+            		OutputStream os = new BufferedOutputStream(content.getOutputStream(), BUFFER_SIZE)) {
+
+                int i;
+                while ((i = is.read()) != -1) {
+                    os.write(i);
                 }
             } catch (final IOException e) {
                 throw new FileSystemException(e.getClass().getName() + " " + e.getMessage());