Refactor AbstractFileObject#getOutputStream() #151

Update patch to avoid some possible if unlikely NPEs.

Author: garydgregory

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java

@@ -319,8 +319,13 @@ public void createFile() throws FileSystemException {
                 }
 
                 if (!exists()) {
-                    getOutputStream().close();
-                    endOutput();
+                    try (FileContent content = getContent()) {
+                        if (content != null) {
+                            try (OutputStream outputStream = content.getOutputStream()) {
+                                // Avoids NPE on OutputStream#close()
+                            }
+                        }
+                    }
                 }
             } catch (final RuntimeException re) {
                 throw re;
@@ -1227,6 +1232,7 @@ public FileName getName() {
         return fileName;
     }
 
+    // TODO: remove this method for the next major version as it is unused
     /**
      * Prepares this file for writing. Makes sure it is either a file, or its parent folder exists. Returns an output
      * stream to use to write the content of the file to.
@@ -1238,6 +1244,8 @@ public OutputStream getOutputStream() throws FileSystemException {
         return getOutputStream(false);
     }
 
+    // TODO: mark this method as `final` and package-private for the next major version because
+    // it shouldn't be used from anywhere other than `DefaultFileContent`
     /**
      * Prepares this file for writing. Makes sure it is either a file, or its parent folder exists. Returns an output
      * stream to use to write the content of the file to.

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileOutputStream.java

@@ -19,8 +19,6 @@
 import java.io.IOException;
 import java.io.OutputStream;
 
-import org.apache.commons.vfs2.FileSystemException;
-
 /**
  * OutputStream to a RamFile.
  */
@@ -57,13 +55,7 @@ public void close() throws IOException {
         if (exception != null) {
             throw exception;
         }
-        try {
-            this.closed = true;
-            // Close the
-            this.file.endOutput();
-        } catch (final Exception e) {
-            throw new FileSystemException(e);
-        }
+        this.closed = true;
     }
 
     @Override

src/changes/changes.xml

@@ -89,6 +89,9 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Arturo Bernal">
         Simplify conditions and avoid extra checks #253.
       </action>
+      <action type="fix" dev="ggregory" due-to="Boris Petrov, Gary Gregory">
+        Refactor AbstractFileObject#getOutputStream() #151.
+      </action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Seth Falco">
         Add vscode files to gitignore #205.