re #VFS-834: Added test cases which test for the bug.

Author: ivakegg

commons-vfs2/src/test/java/org/apache/commons/vfs2/AbstractProviderTestCase.java

@@ -114,14 +114,22 @@ protected void assertSameContent(final String expected, final FileObject file) t
      * are encoded using UTF-8.
      */
     protected void assertSameURLContent(final String expected, final URLConnection connection) throws Exception {
+        assertSameURLContent(expected, connection.getInputStream(), connection);
+    }
+
+    /**
+     * Asserts that the content of a file is the same as expected. Checks the length reported by getContentLength() is
+     * correct, then reads the content as a byte stream and compares the result with the expected content. Assumes files
+     * are encoded using UTF-8.
+     */
+    protected void assertSameURLContent(final String expected, final InputStream instr, final URLConnection connection) throws Exception {
         // Get file content as a binary stream
         final byte[] expectedBin = expected.getBytes(StandardCharsets.UTF_8);
 
         // Check lengths
         assertEquals("same content length", expectedBin.length, connection.getContentLength());
 
         // Read content into byte array
-        final InputStream instr = connection.getInputStream();
         final ByteArrayOutputStream outstr;
         try {
             outstr = new ByteArrayOutputStream();

commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java

@@ -19,6 +19,7 @@
 import static org.apache.commons.vfs2.VfsTestUtils.getTestDirectoryFile;
 
 import java.io.File;
+import java.io.InputStream;
 import java.io.PrintWriter;
 import java.net.URL;
 import java.net.URLConnection;
@@ -196,11 +197,21 @@ public void testLoadClass() throws Exception {
     public void testLoadResource() throws Exception {
         final VFSClassLoader loader = createClassLoader();
 
-        final URL resource = loader.getResource("read-tests/file1.txt");
+        final URL resource1 = loader.getResource("read-tests/file1.txt");
+        assertNotNull(resource1);
+        final URLConnection urlCon1 = resource1.openConnection();
+        final InputStream instr1 = urlCon1.getInputStream();
 
-        assertNotNull(resource);
-        final URLConnection urlCon = resource.openConnection();
-        assertSameURLContent(FILE1_CONTENT, urlCon);
+        // VFS-834: testing that getting the resource again does not close out the previous input stream.
+        final URL resource2 = loader.getResource("read-tests/file1.txt");
+
+        assertSameURLContent(FILE1_CONTENT, instr1, urlCon1);
+
+        assertNotNull(resource2);
+        final URLConnection urlCon2 = resource2.openConnection();
+        final InputStream instr2 = urlCon1.getInputStream();
+
+        assertSameURLContent(FILE1_CONTENT, instr2, urlCon2);
     }
 
     /**