ensure coverage for addTargetDependency with invalid input (#81)

* ensure coverage for addTargetDependency with invalid input

* ensure coverage for addTargetDependency with correct PBX validation

* coverage for dependency target comments in addTargetDependency

* addTargetDependency coverage for proxy container items

* addTargetDependency proxy item container portal comment validation

Author: l3ender

test/addTargetDependency.js

@@ -39,12 +39,16 @@ exports.addTargetDependency = {
     'should throw when target not found in nativeTargetsSection': function (test) {
         test.throws(function() {
             proj.addTargetDependency('invalidTarget');
+        }, function (error) {
+            return (error instanceof Error) && /Invalid target/i.test(error);
         });
         test.done()
     },
     'should throw when any dependency target not found in nativeTargetsSection': function (test) {
         test.throws(function() {
             proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['invalidTarget']);
+        }, function (error) {
+            return (error instanceof Error) && /Invalid target/i.test(error);
         });
         test.done()
     },
@@ -64,6 +68,28 @@ exports.addTargetDependency = {
         test.deepEqual(targetInPbxProj.dependencies, target.dependencies)
         test.done()
     },
+    'should not modify native target dependencies if PBXTargetDependency object does not exist': function (test) {
+        delete proj.hash.project.objects['PBXTargetDependency'];
+
+        var numDependenciesBefore = proj.pbxNativeTargetSection()['1D6058900D05DD3D006BFB54'].dependencies.length;
+        proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54']);
+        var numDependenciesAfter = proj.pbxNativeTargetSection()['1D6058900D05DD3D006BFB54'].dependencies.length;
+
+        test.equal(numDependenciesBefore, numDependenciesAfter);
+
+        test.done();
+    },
+    'should not modify native target dependencies if PBXContainerItemProxy object does not exist': function (test) {
+        delete proj.hash.project.objects['PBXContainerItemProxy'];
+
+        var numDependenciesBefore = proj.pbxNativeTargetSection()['1D6058900D05DD3D006BFB54'].dependencies.length;
+        proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54']);
+        var numDependenciesAfter = proj.pbxNativeTargetSection()['1D6058900D05DD3D006BFB54'].dependencies.length;
+
+        test.equal(numDependenciesBefore, numDependenciesAfter);
+
+        test.done();
+    },
     'should create a PBXTargetDependency for each dependency target': function (test) {
         var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
             target = proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54', '1D6058900D05DD3D006BFB55']).target;
@@ -75,7 +101,7 @@ exports.addTargetDependency = {
 
         test.done()
     },
-    'should set right comment for each dependency target': function (test) {
+    'should set right comment for each target dependency': function (test) {
         var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
             target = proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54', '1D6058900D05DD3D006BFB55']).target;
 
@@ -86,6 +112,22 @@ exports.addTargetDependency = {
 
         test.done()
     },
+    'should set right comment for each dependency target': function (test) {
+        var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
+            target = proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54', '1D6058900D05DD3D006BFB55']).target;
+
+        for (var index = 0; index < target.dependencies.length; index++) {
+            var dependencyTargetUuid = target.dependencies[index].value;
+            var targetDependencyUuid = pbxTargetDependencySection[dependencyTargetUuid].target;
+
+            if (pbxTargetDependencySection[dependencyTargetUuid].target) {
+                var targetCommentKey = targetDependencyUuid + '_comment';
+                test.equal(pbxTargetDependencySection[dependencyTargetUuid].target_comment, proj.pbxNativeTargetSection()[targetCommentKey]);
+            }
+        }
+
+        test.done();
+    },
     'should create a PBXContainerItemProxy for each PBXTargetDependency': function (test) {
         var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
             pbxContainerItemProxySection = proj.hash.project.objects['PBXContainerItemProxy'],
@@ -100,6 +142,26 @@ exports.addTargetDependency = {
 
         test.done()
     },
+    'should set right comment for each container item proxy': function (test) {
+        var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
+            pbxContainerItemProxySection = proj.hash.project.objects['PBXContainerItemProxy'],
+            target = proj.addTargetDependency('1D6058900D05DD3D006BFB54', ['1D6058900D05DD3D006BFB54', '1D6058900D05DD3D006BFB55']).target;
+
+        for (var index = 0; index < target.dependencies.length; index++) {
+            var dependencyTargetUuid = target.dependencies[index].value;
+
+            var proxyUuid = pbxTargetDependencySection[dependencyTargetUuid].targetProxy;
+
+            if (proxyUuid) {
+                test.ok(pbxTargetDependencySection[dependencyTargetUuid].targetProxy_comment, 'PBXContainerItemProxy');
+                test.ok(pbxContainerItemProxySection[proxyUuid]);
+                var proxyCommentKey = proxyUuid + '_comment';
+                test.ok(pbxContainerItemProxySection[proxyCommentKey]);
+            }
+        }
+
+        test.done();
+    },
     'should set each PBXContainerItemProxy`s remoteGlobalIDString correctly': function (test) {
         var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
             pbxContainerItemProxySection = proj.hash.project.objects['PBXContainerItemProxy'],
@@ -146,6 +208,20 @@ exports.addTargetDependency = {
 
         test.done()
     },
+    'should set each PBXContainerItemProxy`s containerPortal_comment correctly': function (test) {
+        var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
+            pbxContainerItemProxySection = proj.hash.project.objects['PBXContainerItemProxy'],
+            target = proj.addTargetDependency('1D6058900D05DD3D006BFB55', ['1D6058900D05DD3D006BFB54', '1D6058900D05DD3D006BFB55']).target;
+
+        for (var index = 0; index < target.dependencies.length; index++) {
+            var dependency = target.dependencies[index].value,
+                targetProxy = pbxTargetDependencySection[dependency]['targetProxy'];
+
+            test.equal(pbxContainerItemProxySection[targetProxy]['containerPortal_comment'], proj.hash.project['rootObject_comment']);
+        }
+
+        test.done()
+    },
     'should set each PBXContainerItemProxy`s proxyType correctly': function (test) {
         var pbxTargetDependencySection = proj.hash.project.objects['PBXTargetDependency'],
             pbxContainerItemProxySection = proj.hash.project.objects['PBXContainerItemProxy'],