Skip to content

Support watch2 apps/extensions #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brody2consult merged 16 commits into from
Oct 21, 2019
+449 −7
Merged

Support watch2 apps/extensions #56

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b4d326f
adds watch2 target/product types
Jun 15, 2019
4ba466d
support adding watch2 app/extension targets
Jun 23, 2019
a0f2592
Merge remote-tracking branch 'upstream/master' into watchkit2-ability
Sep 26, 2019
b9da9d3
add watch app/extension test coverage
Sep 26, 2019
f13bd36
project formatting consistency
Oct 17, 2019
1a2c8cb
coverage for correct watch app extension path name
Oct 17, 2019
4438308
Merge remote-tracking branch 'upstream/master' into watchkit2-ability
Oct 17, 2019
9f2d745
coverage for target type
Oct 17, 2019
314c4c7
ensure non-watch2 extensions additions don't modify watch2 app
Oct 17, 2019
a1b0da2
revert comment - will fix in other pr
Oct 17, 2019
ed70f64
Merge remote-tracking branch 'upstream/master' into watchkit2-ability
Oct 19, 2019
ab22bc2
add test coverage for watch2 product types
Oct 19, 2019
b7bd745
watch2 file/product type test coverage
Oct 19, 2019
ceb33cf
watch2 coverage for target name/extension
Oct 19, 2019
c378c24
clarify watch2 test descriptions
Oct 19, 2019
96c30e0
update comment to keep consistent w/ project
Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/pbxProject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,9 @@ function producttypeForTargettype (targetType) {
static_library: 'com.apple.product-type.library.static',
unit_test_bundle: 'com.apple.product-type.bundle.unit-test',
watch_app: 'com.apple.product-type.application.watchapp',
watch_extension: 'com.apple.product-type.watchkit-extension'
watch2_app: 'com.apple.product-type.application.watchapp2',
watch_extension: 'com.apple.product-type.watchkit-extension',
watch2_extension: 'com.apple.product-type.watchkit2-extension'
};

return PRODUCTTYPE_BY_TARGETTYPE[targetType]
Expand All @@ -1715,7 +1717,9 @@ function filetypeForProducttype (productType) {
'com.apple.product-type.library.static': '"archive.ar"',
'com.apple.product-type.bundle.unit-test': '"wrapper.cfbundle"',
'com.apple.product-type.application.watchapp': '"wrapper.application"',
'com.apple.product-type.watchkit-extension': '"wrapper.app-extension"'
'com.apple.product-type.application.watchapp2': '"wrapper.application"',
'com.apple.product-type.watchkit-extension': '"wrapper.app-extension"',
'com.apple.product-type.watchkit2-extension': '"wrapper.app-extension"',
};

return FILETYPE_BY_PRODUCTTYPE[productType]
Expand Down