Alignment with W3C Battery API#24
Open
pContat wants to merge 9 commits into
Open
Conversation
- CB-7583 : readonly property called charging - CB-7589 : readonly property called level - CB-7585 : readonly property called chargingTime - CB-7587 : readonly property called dischargingTime - CB-7581 : The W3C battery status specification uses promises.
- CB-7581 : Battery information should be accessible from navigator.getBattery() - CB-7584 : event handler: onchargingchange
|
Let there be tests |
|
Is there some way we can rejuvenate this PR? I think this is critical functionality - in particular since the existing implementation does not seem to work on Android 7 as far as I can tell. |
|
I'm a little confused. It seems, that this is implemented in phonegap (the "mirror" of cordova): |
Member
|
That is a fork of this plugin:
So while someone did 15 commits on the fork, it also didn't get 33 commits that happened here. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of the methode navigator.getBattery which return a BatteryManager object using promises to align with the W3C API
Here is the associate Jira issue.
Some notes on the proposed changes:
Also, I was not clear whether there is a coding guideline (formatting, etc) ? I tried to keep it close to the original