CB-13632: (android) Allow UDP media streaming.#155
Conversation
|
Hey, I just fixed the problem that caused Android tests to fail in |
|
Sorry that this PR was left open for quite a long time. I didn’t even start working on Cordova till about a year after this PR was created. Anyways, I have been going through older PRs and trying to find out what could be still relevant, what I understand, and that maybe I could merge. With regards to this PR, allowing UDP is acceptable but IMO, but I would like to refactor this area a step further for the next major release. Ideally to improve flexibility and security. My idea would be that a config preference would be created to allow users to provide the acceptable URL prefixes. For example: <preference name=“MEDIA_STREAMING_ALLOWED_PREFIX” value=“https://,http://” />With the above preference, UDP or anything else in the future could be added without a new PR. Also, the developer could even take their security a step further by providing a more exact URL prefix instead of just schemes. e.g. <preference name=“MEDIA_STREAMING_ALLOWED_PREFIX” value=“https://cordova.apache.org/” />Technically this PR could be merged in as is, but if we do create a config preference in the future for a later major release, the UDP scheme would stop working again as the idea of the plugin is to not accept or open any URL by default. What do you think about this? |
|
If you're planning to refactor how the streaming URLs are determined (personally, I don't have time to dedicate to that), then I don't think it makes sense to merge this PR. I've been using my own fork for almost 5yrs, there's no rush. |
Platforms affected
Android.
What does this PR do?
Handle UDP media URL as streaming.
What testing has been done on this change?
Checklist