CB-13690 : (browser) Add src change to method to Media object#159
Open
f0wu5u wants to merge 4 commits into
Open
CB-13690 : (browser) Add src change to method to Media object#159f0wu5u wants to merge 4 commits into
f0wu5u wants to merge 4 commits into
Conversation
New method to change node src when change audio src, best for playing multiple files/url Release method now unset node src to empty to cancel ongoing network request before collecting garbage
Member
|
jshint is failing: |
Member
|
Tests are now passing. |
f0wu5u
commented
Feb 12, 2019
f0wu5u
left a comment
Author
There was a problem hiding this comment.
Review: Change media src for platform:browser now stops previous stream src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New method to change node src when change audio src, best for playing multiple files/url
Release method now unset node src to empty to cancel ongoing network request before collecting garbage
Platforms affected
browser
What does this PR do?
Add audio src change to media object
What testing has been done on this change?
Checklist