Skip to content

CB-13690 : (browser) Add src change to method to Media object#159

Open
f0wu5u wants to merge 4 commits into
apache:masterfrom
f0wu5u:patch-1
Open

CB-13690 : (browser) Add src change to method to Media object#159
f0wu5u wants to merge 4 commits into
apache:masterfrom
f0wu5u:patch-1

Conversation

@f0wu5u

@f0wu5u f0wu5u commented Dec 20, 2017

Copy link
Copy Markdown

New method to change node src when change audio src, best for playing multiple files/url

Release method now unset node src to empty to cancel ongoing network request before collecting garbage

Platforms affected

browser

What does this PR do?

Add audio src change to media object

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

New method to change node src when change audio src, best for playing multiple files/url

Release method now unset node src to empty to cancel ongoing network request before collecting garbage
@f0wu5u f0wu5u changed the title Added src change to method to Media object Add src change to method to Media object Dec 20, 2017
@f0wu5u f0wu5u changed the title Add src change to method to Media object CB-1369 - (Add src change to method to Media object) Jan 19, 2018
@f0wu5u f0wu5u changed the title CB-1369 - (Add src change to method to Media object) CB-1369 : (browser) Add src change to method to Media object Jan 19, 2018
@f0wu5u f0wu5u changed the title CB-1369 : (browser) Add src change to method to Media object CB-13690 : (browser) Add src change to method to Media object Jan 19, 2018
@janpio

janpio commented Sep 30, 2018

Copy link
Copy Markdown
Member

jshint is failing:

> cordova-plugin-media@5.0.1-dev jshint /home/travis/build/apache/cordova-plugin-media
> jshint www && jshint src && jshint tests
www/browser/Media.js: line 203, col 2, Missing semicolon.
1 error

@janpio

janpio commented Oct 1, 2018

Copy link
Copy Markdown
Member

Tests are now passing.

@f0wu5u f0wu5u left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Change media src for platform:browser now stops previous stream src

@f0wu5u f0wu5u closed this Nov 22, 2019
@f0wu5u f0wu5u reopened this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants