feat: Implement playing audio in background#231
Open
adriano-di-giovanni wants to merge 2 commits into
Open
Conversation
Member
|
Can you please add some documentation in |
Contributor
Author
|
@janpio, done. Thanks. |
Member
|
CI, please rerun the tests with current configuration. |
Contributor
|
As iOS already runs the play command in a background thread anyway, why not just update Android to have the same behaviour by default? No need to introduce any new functions then and the change is backward compatible with any existing implementation of the plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
On iOS, I only added a
startPlayingAudioInBackgroundthat's a proxy tostartPlayingAudiobecause the latter already plays the audio in a background thread.Motivation and Context
Playing audio in a separate thread on Android greatly improved the performance of our apps.
Description
I added
Media.prototype.playInBackgroundto the javascript interface.I added the method
startPlayingAudioInBackgroundto both Android and iOS native interfaces.Testing
The changes are pretty minimal. I installed the plugin in a new cordova project and tested it manually.