minor(aqe): backport few datafusion physical rules identified as not idempotent #1806
Merged
Merged
Conversation
Contributor
Author
|
fyi @wirybeaver |
milenkovicm
changed the title
Contributor
Author
|
for some reason it produces wrong result, keeping it on hold for now |
milenkovicm
force-pushed
the
fix_backport_optimizers
branch
from
6ca78fd to
04abf36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
fix(physical-optimizer): make OutputRequirements idempotent datafusion#22522(removed as it produces wrong result for some reason)rules intensified by @wirybeaver as non idempotent and fixed in datafusion. as it will not get into datafusion 54 i've backported them to ballista codebase for now.
What changes are included in this PR?
two rules copied overAre there any user-facing changes?
no, only affecting AQE which is disabled by default