Skip to content

Commit 11ca1ad

Browse files
committed
fix: exclude release scratch dirs from RAT and sync bash rat excludes
The apache-rat-plugin runs during the verify phase on every install, including the six `mvnw ... install` runs in build-release-comet.sh. RAT walks the root module tree and the exclude list did not cover several untracked generated/scratch directories that accumulate during a release (Python virtualenv, docker workdir, extracted tarballs, rat report files, and the downloaded rat jar). Populated, these make each RAT pass slow and the build appears to hang. Add excludes for those paths to the Maven apache-rat-plugin config. Also reconcile the bash rat exclude list with the Maven excludes: the bash check flagged seven files that Maven already skips (the .claude skill docs, .github/workflows/README.md, and the jni-bridge testdata backtrace/stacktrace fixtures that moved from native/testdata).
1 parent b26a8df commit 11ca1ad

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

dev/release/rat_exclude_files.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
*.gitignore
22
*.dockerignore
33
.github/pull_request_template.md
4+
.github/workflows/README.md
45
.gitmodules
6+
.claude/skills/*/SKILL.md
57
native/Cargo.lock
68
native/testdata/backtrace.txt
79
native/testdata/stacktrace.txt
810
native/core/testdata/backtrace.txt
911
native/core/testdata/stacktrace.txt
12+
native/jni-bridge/testdata/backtrace.txt
13+
native/jni-bridge/testdata/stacktrace.txt
1014
dev/copyright/scala-header.txt
1115
dev/diffs/iceberg/*.diff
1216
dev/release/requirements.txt

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,6 +1167,12 @@ under the License.
11671167
<exclude>docs/source/contributor-guide/*.svg</exclude>
11681168
<exclude>dev/release/rat_exclude_files.txt</exclude>
11691169
<exclude>dev/release/requirements.txt</exclude>
1170+
<exclude>dev/release/venv/**</exclude>
1171+
<exclude>dev/release/comet-rm/workdir/**</exclude>
1172+
<exclude>dev/dist/**</exclude>
1173+
<exclude>dev/release/rat.txt</exclude>
1174+
<exclude>dev/release/filtered_rat.txt</exclude>
1175+
<exclude>dev/release/*.jar</exclude>
11701176
<exclude>native/proto/src/generated/**</exclude>
11711177
<exclude>benchmarks/tpc/queries/**</exclude>
11721178
<exclude>.claude/**</exclude>

0 commit comments

Comments
 (0)