handle literal

Author: parthchandra

spark/src/main/scala/org/apache/comet/serde/literals.scala

@@ -32,7 +32,7 @@ import com.google.protobuf.ByteString
 import org.apache.comet.CometSparkSessionExtensions.withInfo
 import org.apache.comet.DataTypeSupport.isComplexType
 import org.apache.comet.serde.{CometExpressionSerde, Compatible, ExprOuterClass, LiteralOuterClass, SupportLevel, Unsupported}
-import org.apache.comet.serde.QueryPlanSerde.{serializeDataType, supportedDataType}
+import org.apache.comet.serde.QueryPlanSerde.{isTimeType, serializeDataType, supportedDataType}
 import org.apache.comet.serde.Types.ListLiteral
 
 object CometLiteral extends CometExpressionSerde[Literal] with Logging {
@@ -80,6 +80,8 @@ object CometLiteral extends CometExpressionSerde[Literal] with Logging {
         case _: IntegerType | _: DateType => exprBuilder.setIntVal(value.asInstanceOf[Int])
         case _: LongType | _: TimestampType | _: TimestampNTZType =>
           exprBuilder.setLongVal(value.asInstanceOf[Long])
+        case dt if isTimeType(dt) =>
+          exprBuilder.setLongVal(value.asInstanceOf[Long])
         case _: FloatType => exprBuilder.setFloatVal(value.asInstanceOf[Float])
         case _: DoubleType => exprBuilder.setDoubleVal(value.asInstanceOf[Double])
         case _: StringType =>

spark/src/test/resources/sql-tests/expressions/datetime/make_time.sql

@@ -128,3 +128,14 @@ SELECT make_time(0, 0, -1.0)
 -- overflow seconds
 query expect_error(SecondOfMinute)
 SELECT make_time(1, 18, 4294967297.999999)
+
+-- time literal in comparison (make_time with all literals is constant-folded to a Time literal)
+query
+SELECT make_time(12, 30, 0) > make_time(11, 0, 0)
+
+query
+SELECT make_time(0, 0, 0) = make_time(0, 0, 0)
+
+-- current_time() is foldable and produces a Time literal
+query
+SELECT current_time() IS NOT NULL