Skip to content

Commit 1dd81fb

Browse files
committed
fix: qualify CometRLike incompat reasons by engine config
Lift the engine selector into the user-facing reason string so the generated compatibility guide reads the same regardless of which mode is the project default. Future Java-engine-specific incompatibilities can be appended with the matching qualifier.
1 parent 5937650 commit 1dd81fb

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

spark/src/main/scala/org/apache/comet/serde/strings.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,8 @@ object CometLike extends CometExpressionSerde[Like] {
264264
object CometRLike extends CometExpressionSerde[RLike] {
265265

266266
override def getIncompatibleReasons(): Seq[String] = Seq(
267-
"Uses Rust regexp engine, which has different behavior to Java regexp engine")
267+
s"When ${CometConf.COMET_REGEXP_ENGINE.key}=${CometConf.REGEXP_ENGINE_RUST}: " +
268+
"Uses Rust regexp engine, which has different behavior to Java regexp engine")
268269

269270
override def getSupportLevel(expr: RLike): SupportLevel = {
270271
if (CometConf.COMET_REGEXP_ENGINE.get() == CometConf.REGEXP_ENGINE_JAVA) {

0 commit comments

Comments
 (0)