cleanup and clippy

Author: parthchandra

native/core/src/execution/columnar_to_row.rs

@@ -674,6 +674,7 @@ impl<'a> TypedElements<'a> {
             TypedElements::Float64(arr) => bulk_copy_range!(arr, 8),
             TypedElements::Date32(arr) => bulk_copy_range!(arr, 4),
             TypedElements::TimestampMicro(arr) => bulk_copy_range!(arr, 8),
+            TypedElements::Time64Nano(arr) => bulk_copy_range!(arr, 8),
             _ => {} // Should not reach here due to supports_bulk_copy check
         }
     }
@@ -846,7 +847,8 @@ fn is_fixed_width(data_type: &DataType) -> bool {
         | DataType::Float32
         | DataType::Float64
         | DataType::Date32
-        | DataType::Timestamp(TimeUnit::Microsecond, _) => true,
+        | DataType::Timestamp(TimeUnit::Microsecond, _)
+        | DataType::Time64(TimeUnit::Nanosecond) => true,
         DataType::Decimal128(p, _) => *p <= MAX_LONG_DIGITS,
         _ => false,
     }
@@ -1254,6 +1256,15 @@ impl ColumnarToRowContext {
                 TimestampMicrosecondArray,
                 |v: i64| v
             ),
+            DataType::Time64(TimeUnit::Nanosecond) => write_fixed_column_primitive!(
+                self,
+                array,
+                row_size,
+                field_offset_in_row,
+                num_rows,
+                Time64NanosecondArray,
+                |v: i64| v
+            ),
             DataType::Decimal128(precision, _) if *precision <= MAX_LONG_DIGITS => {
                 write_fixed_column_primitive!(
                     self,
@@ -1379,6 +1390,9 @@ fn get_field_value(data_type: &DataType, array: &ArrayRef, row_idx: usize) -> Co
         DataType::Timestamp(TimeUnit::Microsecond, _) => {
             get_field_value_primitive!(array, row_idx, TimestampMicrosecondArray, |v: i64| v)
         }
+        DataType::Time64(TimeUnit::Nanosecond) => {
+            get_field_value_primitive!(array, row_idx, Time64NanosecondArray, |v: i64| v)
+        }
         DataType::Decimal128(precision, _) if *precision <= MAX_LONG_DIGITS => {
             get_field_value_primitive!(array, row_idx, Decimal128Array, |v: i128| v as i64)
         }

native/spark-expr/src/datetime_funcs/to_time.rs

@@ -333,7 +333,7 @@ mod tests {
             Some(1_000 * NANOS_PER_MICRO)
         );
         // 6 digits
-        assert_eq!(string_to_time("00:00:00.000001"), Some(1 * NANOS_PER_MICRO));
+        assert_eq!(string_to_time("00:00:00.000001"), Some(NANOS_PER_MICRO));
         // Full precision
         assert_eq!(
             string_to_time("23:59:59.999999"),
@@ -351,12 +351,12 @@ mod tests {
         // Single digit hour, minute, second
         assert_eq!(
             string_to_time("1:2:3"),
-            Some(1 * NANOS_PER_HOUR + 2 * NANOS_PER_MINUTE + 3 * NANOS_PER_SECOND)
+            Some(NANOS_PER_HOUR + 2 * NANOS_PER_MINUTE + 3 * NANOS_PER_SECOND)
         );
         assert_eq!(
             string_to_time("1:2:3.04"),
             Some(
-                1 * NANOS_PER_HOUR
+                NANOS_PER_HOUR
                     + 2 * NANOS_PER_MINUTE
                     + 3 * NANOS_PER_SECOND
                     + 40_000 * NANOS_PER_MICRO
@@ -369,7 +369,7 @@ mod tests {
         assert_eq!(
             string_to_time("T1:02:3.04"),
             Some(
-                1 * NANOS_PER_HOUR
+                NANOS_PER_HOUR
                     + 2 * NANOS_PER_MINUTE
                     + 3 * NANOS_PER_SECOND
                     + 40_000 * NANOS_PER_MICRO
@@ -386,7 +386,7 @@ mod tests {
         // 12:00:00 AM = midnight
         assert_eq!(string_to_time("12:00:00 AM"), Some(0));
         // 1:00:00 AM
-        assert_eq!(string_to_time("1:00:00 AM"), Some(1 * NANOS_PER_HOUR));
+        assert_eq!(string_to_time("1:00:00 AM"), Some(NANOS_PER_HOUR));
         // 11:59:59 AM
         assert_eq!(
             string_to_time("11:59:59 AM"),